* org-mouse.el 1.10 released, compatible with org-mode 4.21
@ 2006-04-12 9:59 Piotr Zielinski
2006-04-13 7:40 ` org-mouse.el Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Piotr Zielinski @ 2006-04-12 9:59 UTC (permalink / raw)
To: emacs-orgmode
I've just fixed an incompatibility bug, which prevented org-mouse from
operating correctly with org-mode 4.21. Here's the latest version:
http://www.cl.cam.ac.uk/~pz215/files/org-mouse.el
Bug reports welcome
Piotr
^ permalink raw reply [flat|nested] 3+ messages in thread
* org-mouse.el
2006-04-12 9:59 org-mouse.el 1.10 released, compatible with org-mode 4.21 Piotr Zielinski
@ 2006-04-13 7:40 ` Carsten Dominik
2006-04-13 10:24 ` org-mouse.el Piotr Zielinski
0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2006-04-13 7:40 UTC (permalink / raw)
To: emacs-orgmode
On Apr 12, 2006, at 11:59, Piotr Zielinski wrote:
> I've just fixed an incompatibility bug, which prevented org-mouse from
> operating correctly with org-mode 4.21. Here's the latest version:
I really like org-mouse.el, in particular the menus with
TODO keywords, tags and priorities.
In the latest version, the context menu on links does not seem to work
- on links I still get the context menu for normal text. At first I
thought this was only for the new bracket links, but it is the same for
all link types, because `org-mouse-at-link' never returns t.
While looking at this function I realized that org.el and org-mouse.el
could check for a link at the cursor position in a much simpler way:
(defun org-mouse-at-link ()
(and (eq (get-text-property (point) 'face) 'org-link)
(save-excursion
(goto-char (previous-single-property-change (point) 'face))
(or (looking-at org-bracket-link-regexp)
(looking-at org-angle-link-re)
(looking-at org-plain-link-re)))))
This implementation depends on having font-lock active, but then a lot
of functionality in org-mode depends on that.
One more thing. I am totally used now to the fact that mouse-1 does
follow a link in Org-mode buffers, this feels completely natural. But
I am not so sure in agenda buffers. Since almost every line in that
buffer has a mouse-face property, pretty much any click in the agenda
window will send the cursor off into another buffer and window. I
would like to be able to customize this. In org.el 4.22 (on the web
now, with a few bug fixes), there is a new variable
`org-agenda-mouse-1-follows-link'. Right now, org-mouse.el does
overrule this. Could org-mouse.el honor this variable or even better no
longer put those bindings to [follow-link] at all because org.el does
this already?
Thanks.
- Carsten
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: org-mouse.el
2006-04-13 7:40 ` org-mouse.el Carsten Dominik
@ 2006-04-13 10:24 ` Piotr Zielinski
0 siblings, 0 replies; 3+ messages in thread
From: Piotr Zielinski @ 2006-04-13 10:24 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
On 13/04/06, Carsten Dominik <dominik@science.uva.nl> wrote:
> In the latest version, the context menu on links does not seem to work
Yes, the org-mouse-at-link function has never been particularly
elegant: I had simply copied a fragment of org.el, this is why it was
so sensitive to changes in org-mode.
Your suggestion is much better in this respect. I've put it into
org-mouse.el, thanks.
> One more thing. [...] Could org-mouse.el honor this
> variable or even better no longer put those bindings to
> [follow-link] at all because org.el does this already?
Done.
Thanks,
Piotr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-04-13 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-12 9:59 org-mouse.el 1.10 released, compatible with org-mode 4.21 Piotr Zielinski
2006-04-13 7:40 ` org-mouse.el Carsten Dominik
2006-04-13 10:24 ` org-mouse.el Piotr Zielinski
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).