From: Carsten Dominik <dominik@science.uva.nl>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-remember: Ignore gnus link if not on a message
Date: Tue, 20 Jan 2009 18:17:19 +0100 [thread overview]
Message-ID: <3DB917C3-A151-4FE3-BB2A-A64DCC0D196B@uva.nl> (raw)
In-Reply-To: <1232469469-10629-1-git-send-email-bernt@norang.ca>
Applied, thanks.
- Carsten
On Jan 20, 2009, at 5:37 PM, Bernt Hansen wrote:
> This allows you to use org-remember in any gnus buffer - even when
> not on a location that will create a usable link. Instead of
> failing with the error "Not on a group" just create a remember
> note with no link instead.
>
> This makes org-remember more user-friendly - we don't have to
> change buffers to a non-gnus buffer to create a remember note.
> ---
> Carsten: This patch is available at git://git.norang.ca/org-mode for-
> carsten
>
> lisp/org-gnus.el | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
> index 23b2809..7826eba 100644
> --- a/lisp/org-gnus.el
> +++ b/lisp/org-gnus.el
> @@ -111,12 +111,12 @@ If `org-store-link' was called with a prefix
> arg the meaning of
> (gnus-group-name))
> (t "???")))
> desc link)
> - (unless group (error "Not on a group"))
> - (org-store-link-props :type "gnus" :group group)
> - (setq desc (org-gnus-group-link group)
> - link desc)
> - (org-add-link-props :link link :description desc)
> - link))
> + (when group
> + (org-store-link-props :type "gnus" :group group)
> + (setq desc (org-gnus-group-link group)
> + link desc)
> + (org-add-link-props :link link :description desc)
> + link)))
>
> ((memq major-mode '(gnus-summary-mode gnus-article-mode))
> (and (eq major-mode 'gnus-summary-mode) (gnus-summary-show-
> article))
> --
> 1.6.1.28.gc32f76
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2009-01-20 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 16:37 [PATCH] org-remember: Ignore gnus link if not on a message Bernt Hansen
2009-01-20 17:17 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DB917C3-A151-4FE3-BB2A-A64DCC0D196B@uva.nl \
--to=dominik@science.uva.nl \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).