emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: emacs-orgmode@gnu.org
Cc: Bernt Hansen <bernt@norang.ca>
Subject: [PATCH] org-remember: Ignore gnus link if not on a message
Date: Tue, 20 Jan 2009 11:37:49 -0500	[thread overview]
Message-ID: <1232469469-10629-1-git-send-email-bernt@norang.ca> (raw)

This allows you to use org-remember in any gnus buffer - even when
not on a location that will create a usable link.  Instead of
failing with the error "Not on a group" just create a remember
note with no link instead.

This makes org-remember more user-friendly - we don't have to
change buffers to a non-gnus buffer to create a remember note.
---
Carsten: This patch is available at git://git.norang.ca/org-mode for-carsten

 lisp/org-gnus.el |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index 23b2809..7826eba 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -111,12 +111,12 @@ If `org-store-link' was called with a prefix arg the meaning of
 			 (gnus-group-name))
 			(t "???")))
 	   desc link)
-      (unless group (error "Not on a group"))
-      (org-store-link-props :type "gnus" :group group)
-      (setq desc (org-gnus-group-link group)
-	    link desc)
-      (org-add-link-props :link link :description desc)
-      link))
+      (when group
+	(org-store-link-props :type "gnus" :group group)
+	(setq desc (org-gnus-group-link group)
+	      link desc)
+	(org-add-link-props :link link :description desc)
+	link)))
 
    ((memq major-mode '(gnus-summary-mode gnus-article-mode))
     (and (eq major-mode 'gnus-summary-mode) (gnus-summary-show-article))
-- 
1.6.1.28.gc32f76

             reply	other threads:[~2009-01-20 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 16:37 Bernt Hansen [this message]
2009-01-20 17:17 ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232469469-10629-1-git-send-email-bernt@norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] org-remember: Ignore gnus link if not on a message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).