* PATCH Bugfix: bulk mark/unmark selects wrong next item when restricted
@ 2010-01-02 21:45 Paul Holcomb
2010-01-03 12:56 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Paul Holcomb @ 2010-01-02 21:45 UTC (permalink / raw)
To: Org Mode
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
When you are in agenda view and limit the items that are visible,
such as with a tag restriction, marking and unmarking behaves
incorrectly. After the item is marked or unmarked for bulk action,
the point is moved to the next item, regardless of whether the next item
is visible.
--
Paul Holcomb *pholcomb \@ cpoint net*
GPG key fingerprint 2B62 05AE EE74 845A 705F D716 28C4 FE1C 088F CFAC
[-- Attachment #2: org-agenda.el-bulkmark.patch --]
[-- Type: text/plain, Size: 988 bytes --]
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index da60310..670b4b0 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7057,7 +7057,7 @@ This is a command that has to be installed in `calendar-mode-map'."
(org-get-todo-face "TODO")
'evaporate)
(org-overlay-put ov 'type 'org-marked-entry-overlay))
- (beginning-of-line 2)
+ (org-agenda-next-line)
(message "%d entries marked for bulk action"
(length org-agenda-bulk-marked-entries))))
@@ -7070,8 +7070,8 @@ This is a command that has to be installed in `calendar-mode-map'."
(setq org-agenda-bulk-marked-entries
(delete (org-get-at-bol 'org-hd-marker)
org-agenda-bulk-marked-entries)))
- (beginning-of-line 2)
- (message "%d entries marked for bulk action"
+ (org-agenda-next-line)
+(message "%d entries marked for bulk action"
(length org-agenda-bulk-marked-entries)))
(defun org-agenda-bulk-toggle ()
[-- Attachment #3: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: PATCH Bugfix: bulk mark/unmark selects wrong next item when restricted
2010-01-02 21:45 PATCH Bugfix: bulk mark/unmark selects wrong next item when restricted Paul Holcomb
@ 2010-01-03 12:56 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-01-03 12:56 UTC (permalink / raw)
To: pholcomb; +Cc: Org Mode
Hi Paul,
On Jan 2, 2010, at 10:45 PM, Paul Holcomb wrote:
>
> When you are in agenda view and limit the items that are visible,
> such as with a tag restriction, marking and unmarking behaves
> incorrectly. After the item is marked or unmarked for bulk action,
> the point is moved to the next item, regardless of whether the next
> item
> is visible.
The move to the next line is intentional, to make it easy to mark
consecutive lines. But you are of course correct that this should not
be an
invisible line.
Fixed, thanks!
- Carsten
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-03 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-02 21:45 PATCH Bugfix: bulk mark/unmark selects wrong next item when restricted Paul Holcomb
2010-01-03 12:56 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).