emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Phil Estival <pe@7d.nz>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox: fix comment exported as a blank line
Date: Thu, 2 Jun 2022 07:02:50 +0200	[thread overview]
Message-ID: <20b5709c-0def-c898-a0db-40322b5a3f1b@7d.nz> (raw)
In-Reply-To: <18449694-8ad1-3f0c-d18a-3b6fd5369478@gmail.com>

Le 01/06/2022 à 13:48, Max Nikulin wrote :
> On 01/06/2022 12:30, Phil Estival wrote:
>> * lisp/ox.el (org-export--skip-p): no longer export single-line
>> comments as blank lines which did break paragraphs in two.
> unfortunately, you took a wrong direction
> If you are interested in other cases when org paragraph is not the same
> as exported LaTeX one, see the following thread:
> Max Nikulin. Comments break up a paragraph when writing
> one-setence-per-line. Sun, 3 Oct 2021 18:34:10 +0700.
> https://list.orgmode.org/sjc4fk$76r$1@ciao.gmane.io


Right, thanks for the clarifications.

A hook at pre-export stage to filter out the
line-comments is one correct way to get an output
compliant with different backends. Yet the removal
of comments may provide an AST different from the
one of the emacs buffer.

 >> However there [are] users in this thread who
 >> expect that "# " or "#+latex:" should not be
 >> "element" and should be a part of surrounding
 >> paragraph.

That's an interesting idea.  This would add an
attribute to the previous element.

If we keep speculating on that, the rendering path
would change. It would have to consider this
property too when showing or hiding elements.

And it would require additional function to
reallocate this attribute like a node.

And this would probably break some conceptual

The org spec is correct to handle the comments the
way it does. As I see it now, that's the only
possible attempts to reconcile the behaviors of
different backends.

Still, the writing experience is much improved
when comments are allowed inside paragraphs
without disrupting the publication, and this
definitely worth a few modifications.


  reply	other threads:[~2022-06-02  5:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  5:30 [PATCH] ox: fix comment exported as a blank line Phil Estival
2022-06-01  5:43 ` [PATCH] test-ox: no superfluous newline in exported comments Phil Estival
2022-06-01 11:48 ` [PATCH] ox: fix comment exported as a blank line Max Nikulin
2022-06-02  5:02   ` Phil Estival [this message]
2022-06-02 16:09     ` Max Nikulin
2022-06-01 13:14 ` Kaushal Modi
2022-07-04 11:47 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20b5709c-0def-c898-a0db-40322b5a3f1b@7d.nz \
    --to=pe@7d.nz \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).