emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Phil Estival <pe@7d.nz>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ox: fix comment exported as a blank line
Date: Wed, 1 Jun 2022 09:14:27 -0400	[thread overview]
Message-ID: <CAFyQvY1rq-7BK0wLv8ZPskBA5UsvW=QBWT-ZmCOP5GALJyE9uA@mail.gmail.com> (raw)
In-Reply-To: <87618398-cf6d-86b4-ba59-144f70d0f96e@7d.nz>

On Wed, Jun 1, 2022 at 1:32 AM Phil Estival <pe@7d.nz> wrote:
> * lisp/ox.el (org-export--skip-p): no longer export single-line
> comments as blank lines which did break paragraphs in two.

This is a pretty big breaking change. In your next PATCH email, I see
that you are also modifying the test that ensures that a comment line
gets parsed as a paragraph break.

  parent reply	other threads:[~2022-06-01 13:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  5:30 [PATCH] ox: fix comment exported as a blank line Phil Estival
2022-06-01  5:43 ` [PATCH] test-ox: no superfluous newline in exported comments Phil Estival
2022-06-01 11:48 ` [PATCH] ox: fix comment exported as a blank line Max Nikulin
2022-06-02  5:02   ` Phil Estival
2022-06-02 16:09     ` Max Nikulin
2022-06-01 13:14 ` Kaushal Modi [this message]
2022-07-04 11:47 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY1rq-7BK0wLv8ZPskBA5UsvW=QBWT-ZmCOP5GALJyE9uA@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=pe@7d.nz \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).