emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bugs in org-remember-backup-directory
@ 2009-04-25 22:08 Samuel Wales
  2009-04-30 13:30 ` Carsten Dominik
  0 siblings, 1 reply; 10+ messages in thread
From: Samuel Wales @ 2009-04-25 22:08 UTC (permalink / raw)
  To: emacs-orgmode

I noticed the following regarding
org-remember-backup-directory:

  1) auto-saving does not save contents
     - solution: put (auto-save-mode 1) before or after (not
       sure which) the call to org-set-local in the
       following lines in org-remember:

        # 	  (expand-file-name
        # 	   (format-time-string "remember-%Y-%m-%d-%H-%M-%S")
        # 	   org-remember-backup-directory))
        #     (save-buffer)
        #     (org-set-local 'auto-save-visited-file-name t))
        #   (when (save-excursion

  2) save-buffer is called before there are any contents
     - this causes files without useful content to stick
       around in the dir if the buffer is killed or
       something.
     - solution: don't save the buffer; let auto-saving do
       that work.  will this work?
  3) if you have auto-save-file-name-transforms set,
     auto-saving is done according to that variable instead
     of saving in place.
     - solution: is this an emacs bug?  i am not sure.  the
       auto-saving should be done in place, saving in
       org-remember-backup-directory and not saving in the
       place where the transforms variable tells it to save.
       perhaps each user can kludge transforms or perhaps
       emacs needs fixing?  i have reached debugging ability
       limit.

Thanks.

-- 
Myalgic encephalomyelitis denialism is causing death and severe suffering
worse than MS.  Greed is corrupting science into foul nonsense.  Anybody can
get the disease at any time permanently.  Do science and justice matter to
you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-04-25 22:08 bugs in org-remember-backup-directory Samuel Wales
@ 2009-04-30 13:30 ` Carsten Dominik
  2009-05-04 17:14   ` Samuel Wales
  0 siblings, 1 reply; 10+ messages in thread
From: Carsten Dominik @ 2009-04-30 13:30 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode


On Apr 26, 2009, at 12:08 AM, Samuel Wales wrote:

> I noticed the following regarding
> org-remember-backup-directory:
>
>  1) auto-saving does not save contents
>     - solution: put (auto-save-mode 1) before or after (not
>       sure which) the call to org-set-local in the
>       following lines in org-remember:
>
>        # 	  (expand-file-name
>        # 	   (format-time-string "remember-%Y-%m-%d-%H-%M-%S")
>        # 	   org-remember-backup-directory))
>        #     (save-buffer)
>        #     (org-set-local 'auto-save-visited-file-name t))
>        #   (when (save-excursion

Done.

>
>  2) save-buffer is called before there are any contents
>     - this causes files without useful content to stick
>       around in the dir if the buffer is killed or
>       something.
>     - solution: don't save the buffer; let auto-saving do
>       that work.  will this work?

Usually, the template expansion will have filled in stuff like
links and initial contents, so I would prefer to keep the
save-buffer here and let the user deal with the extra files.

>  3) if you have auto-save-file-name-transforms set,
>     auto-saving is done according to that variable instead
>     of saving in place.

I am now turning that variable off, locally in the remember buffer.
Does that fix the problem?

- Carsten

>     - solution: is this an emacs bug?  i am not sure.  the
>       auto-saving should be done in place, saving in
>       org-remember-backup-directory and not saving in the
>       place where the transforms variable tells it to save.
>       perhaps each user can kludge transforms or perhaps
>       emacs needs fixing?  i have reached debugging ability
>       limit.
>
> Thanks.
>
> --  
> Myalgic encephalomyelitis denialism is causing death and severe  
> suffering
> worse than MS.  Greed is corrupting science into foul nonsense.   
> Anybody can
> get the disease at any time permanently.  Do science and justice  
> matter to
> you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-04-30 13:30 ` Carsten Dominik
@ 2009-05-04 17:14   ` Samuel Wales
  2009-05-04 17:57     ` Samuel Wales
  0 siblings, 1 reply; 10+ messages in thread
From: Samuel Wales @ 2009-05-04 17:14 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Thanks, Carsten.  Welcome back :).

On Thu, Apr 30, 2009 at 06:30, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
>>  3) if you have auto-save-file-name-transforms set,
>>    auto-saving is done according to that variable instead
>>    of saving in place.
>
> I am now turning that variable off, locally in the remember buffer.
> Does that fix the problem?

Yes, it works well in my limited testing.

However, dired-find-file does not work on the file.  It seems that it
thinks there is no buffer visiting it even though there is one.

Thanks.

-- 
Myalgic encephalomyelitis denialism is causing death and severe suffering
worse than MS.  Conflicts of interest are destroying science.  Anybody can
get the disease at any time permanently.  Do science and justice matter to
you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-05-04 17:14   ` Samuel Wales
@ 2009-05-04 17:57     ` Samuel Wales
  2009-06-04 14:40       ` Carsten Dominik
  0 siblings, 1 reply; 10+ messages in thread
From: Samuel Wales @ 2009-05-04 17:57 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

I found another bug.  After an auto-save happens, if you change the
remember buffer, then do org-remember-finalize, emacs will complain
that remember-... has changed since you last saved it.  If you then
run do-auto-save and try to save it, it works.

A workaround would be to put (do-auto-save) in org-remember-finalize.
That would work perfectly, but feels kludgey.  Perhaps there is a way
to turn off checking for changes.

Thanks.

-- 
Myalgic encephalomyelitis denialism is causing death and severe suffering
worse than MS.  Conflicts of interest are destroying science.  Anybody can
get the disease at any time permanently.  Do science and justice matter to
you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-05-04 17:57     ` Samuel Wales
@ 2009-06-04 14:40       ` Carsten Dominik
  2009-06-04 21:29         ` Samuel Wales
  0 siblings, 1 reply; 10+ messages in thread
From: Carsten Dominik @ 2009-06-04 14:40 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode


On May 4, 2009, at 7:57 PM, Samuel Wales wrote:

> I found another bug.  After an auto-save happens, if you change the
> remember buffer, then do org-remember-finalize, emacs will complain
> that remember-... has changed since you last saved it.

I don't seem to be able to reproduce this.

- Carsten

>  If you then
> run do-auto-save and try to save it, it works.
>
> A workaround would be to put (do-auto-save) in org-remember-finalize.
> That would work perfectly, but feels kludgey.  Perhaps there is a way
> to turn off checking for changes.



>
> Thanks.
>
> --  
> Myalgic encephalomyelitis denialism is causing death and severe  
> suffering
> worse than MS.  Conflicts of interest are destroying science.   
> Anybody can
> get the disease at any time permanently.  Do science and justice  
> matter to
> you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-06-04 14:40       ` Carsten Dominik
@ 2009-06-04 21:29         ` Samuel Wales
  2009-06-05  3:59           ` Samuel Wales
  0 siblings, 1 reply; 10+ messages in thread
From: Samuel Wales @ 2009-06-04 21:29 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Seems OK so far in newest git.  Will monitor.

Thanks.

-- 
Myalgic encephalomyelitis denialism is causing death and severe suffering,
worse than MS.  Conflicts of interest are destroying research.  /You/ can
get the disease at any time permanently.  Do science and justice matter to
you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-06-04 21:29         ` Samuel Wales
@ 2009-06-05  3:59           ` Samuel Wales
  2009-06-05  7:00             ` Carsten Dominik
  2009-06-26 22:27             ` Samuel Wales
  0 siblings, 2 replies; 10+ messages in thread
From: Samuel Wales @ 2009-06-05  3:59 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

The bug still exists.

To reproduce, run emacs -Q --load <the minimal setup below>, remember
a task, make enough changes to trigger do-auto-save, then c-x c-s.  It
should tell you it has changed and ask if you want to save.

You will have to set 3 env vars for dirs of your choice.
I didn't want to risk making dirs for you.

(require 'cl)

(defun alpha-add-path (p) (setq load-path (cons p load-path)))

(alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
(alpha-add-path (concat (getenv "delpkgbef") "/remember"))

(add-to-list 'auto-mode-alist '("\\.org$" . org-mode))

(defvar alpha-mac-font
  "-apple-courier-medium-r-normal--24-240-72-72-m-240-iso10646-1")
'(progn
  (progn
    (defconst alpha-mac-font-2
      "-apple-courier-medium-r-normal--*-*-*-*-*-240-*")
    (set-frame-font alpha-mac-font-2))
  )
(set-frame-font alpha-mac-font)

(require 'org-install)

(defvar alpha-org-map (make-sparse-keymap "alpha org map"))
(define-key global-map [f8] alpha-org-map)
(define-key alpha-org-map [f8] 'org-remember)             ;c-c r
(define-key alpha-org-map "o" 'org-open-at-point-global) ;c-c o

(require 'remember-autoloads)
(org-remember-insinuate)

(setq org-remember-templates
      `(("conversation" ?c    "* CONVERSATION %U %?\n%i")))

(add-hook 'remember-mode-hook 'delete-other-windows)
(setf org-remember-backup-directory
      (getenv "demacsremember"))
;;;(setf org-remember-backup-directory nil)
(add-hook 'org-remember-mode-hook
          (lambda () (when org-remember-backup-directory
                       (cd org-remember-backup-directory))))
(add-hook 'org-remember-mode-hook
          (lambda ()
            (define-key org-remember-mode-map
                "\C-x\C-s" 'org-remember-finalize)
            ;;i think org-mode-map will override?
            (define-key org-remember-mode-map
                "\C-c\C-c" nil)))

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-06-05  3:59           ` Samuel Wales
@ 2009-06-05  7:00             ` Carsten Dominik
  2009-06-18 22:59               ` Samuel Wales
  2009-06-26 22:27             ` Samuel Wales
  1 sibling, 1 reply; 10+ messages in thread
From: Carsten Dominik @ 2009-06-05  7:00 UTC (permalink / raw)
  To: Samuel Wales; +Cc: emacs-orgmode

I am still unable to reproduce this.

Anyone?

- Carsten

On Jun 5, 2009, at 5:59 AM, Samuel Wales wrote:

> The bug still exists.
>
> To reproduce, run emacs -Q --load <the minimal setup below>, remember
> a task, make enough changes to trigger do-auto-save, then c-x c-s.  It
> should tell you it has changed and ask if you want to save.
>
> You will have to set 3 env vars for dirs of your choice.
> I didn't want to risk making dirs for you.
>
> (require 'cl)
>
> (defun alpha-add-path (p) (setq load-path (cons p load-path)))
>
> (alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
> (alpha-add-path (concat (getenv "delpkgbef") "/remember"))
>
> (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
>
> (defvar alpha-mac-font
>  "-apple-courier-medium-r-normal--24-240-72-72-m-240-iso10646-1")
> '(progn
>  (progn
>    (defconst alpha-mac-font-2
>      "-apple-courier-medium-r-normal--*-*-*-*-*-240-*")
>    (set-frame-font alpha-mac-font-2))
>  )
> (set-frame-font alpha-mac-font)
>
> (require 'org-install)
>
> (defvar alpha-org-map (make-sparse-keymap "alpha org map"))
> (define-key global-map [f8] alpha-org-map)
> (define-key alpha-org-map [f8] 'org-remember)             ;c-c r
> (define-key alpha-org-map "o" 'org-open-at-point-global) ;c-c o
>
> (require 'remember-autoloads)
> (org-remember-insinuate)
>
> (setq org-remember-templates
>      `(("conversation" ?c    "* CONVERSATION %U %?\n%i")))
>
> (add-hook 'remember-mode-hook 'delete-other-windows)
> (setf org-remember-backup-directory
>      (getenv "demacsremember"))
> ;;;(setf org-remember-backup-directory nil)
> (add-hook 'org-remember-mode-hook
>          (lambda () (when org-remember-backup-directory
>                       (cd org-remember-backup-directory))))
> (add-hook 'org-remember-mode-hook
>          (lambda ()
>            (define-key org-remember-mode-map
>                "\C-x\C-s" 'org-remember-finalize)
>            ;;i think org-mode-map will override?
>            (define-key org-remember-mode-map
>                "\C-c\C-c" nil)))

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-06-05  7:00             ` Carsten Dominik
@ 2009-06-18 22:59               ` Samuel Wales
  0 siblings, 0 replies; 10+ messages in thread
From: Samuel Wales @ 2009-06-18 22:59 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Strange that it is not reproducible even with the minimal startup.

It happens to me every time I save a remember that is long enough to
trigger auto-save.

On Fri, Jun 5, 2009 at 00:00, Carsten Dominik<carsten.dominik@gmail.com> wrote:
> I am still unable to reproduce this.
>
> Anyone?
>
> - Carsten
>
> On Jun 5, 2009, at 5:59 AM, Samuel Wales wrote:
>
>> The bug still exists.
>>
>> To reproduce, run emacs -Q --load <the minimal setup below>, remember
>> a task, make enough changes to trigger do-auto-save, then c-x c-s.  It
>> should tell you it has changed and ask if you want to save.
>>
>> You will have to set 3 env vars for dirs of your choice.
>> I didn't want to risk making dirs for you.
>>
>> (require 'cl)
>>
>> (defun alpha-add-path (p) (setq load-path (cons p load-path)))
>>
>> (alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
>> (alpha-add-path (concat (getenv "delpkgbef") "/remember"))
>>
>> (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
>>
>> (defvar alpha-mac-font
>>  "-apple-courier-medium-r-normal--24-240-72-72-m-240-iso10646-1")
>> '(progn
>>  (progn
>>   (defconst alpha-mac-font-2
>>     "-apple-courier-medium-r-normal--*-*-*-*-*-240-*")
>>   (set-frame-font alpha-mac-font-2))
>>  )
>> (set-frame-font alpha-mac-font)
>>
>> (require 'org-install)
>>
>> (defvar alpha-org-map (make-sparse-keymap "alpha org map"))
>> (define-key global-map [f8] alpha-org-map)
>> (define-key alpha-org-map [f8] 'org-remember)             ;c-c r
>> (define-key alpha-org-map "o" 'org-open-at-point-global) ;c-c o
>>
>> (require 'remember-autoloads)
>> (org-remember-insinuate)
>>
>> (setq org-remember-templates
>>     `(("conversation" ?c    "* CONVERSATION %U %?\n%i")))
>>
>> (add-hook 'remember-mode-hook 'delete-other-windows)
>> (setf org-remember-backup-directory
>>     (getenv "demacsremember"))
>> ;;;(setf org-remember-backup-directory nil)
>> (add-hook 'org-remember-mode-hook
>>         (lambda () (when org-remember-backup-directory
>>                      (cd org-remember-backup-directory))))
>> (add-hook 'org-remember-mode-hook
>>         (lambda ()
>>           (define-key org-remember-mode-map
>>               "\C-x\C-s" 'org-remember-finalize)
>>           ;;i think org-mode-map will override?
>>           (define-key org-remember-mode-map
>>               "\C-c\C-c" nil)))
>
>



-- 
Myalgic encephalomyelitis denialism is causing death and severe suffering,
worse than MS.  Conflicts of interest are destroying research.  /You/ can
get the disease at any time permanently.  Do science and justice matter to
you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: bugs in org-remember-backup-directory
  2009-06-05  3:59           ` Samuel Wales
  2009-06-05  7:00             ` Carsten Dominik
@ 2009-06-26 22:27             ` Samuel Wales
  1 sibling, 0 replies; 10+ messages in thread
From: Samuel Wales @ 2009-06-26 22:27 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

If org-remember-finalize

  (when buffer-file-name
    (save-buffer))

is only for org-remember-directory purposes, then perhaps running
do-auto-save instead of save-buffer will fix the bug.

Thanks.

On Thu, Jun 4, 2009 at 20:59, Samuel Wales<samologist@gmail.com> wrote:
> The bug still exists.
>
> To reproduce, run emacs -Q --load <the minimal setup below>, remember
> a task, make enough changes to trigger do-auto-save, then c-x c-s.  It
> should tell you it has changed and ask if you want to save.
>
> You will have to set 3 env vars for dirs of your choice.
> I didn't want to risk making dirs for you.
>
> (require 'cl)
>
> (defun alpha-add-path (p) (setq load-path (cons p load-path)))
>
> (alpha-add-path (concat (getenv "delorgsrc") "/lisp"))
> (alpha-add-path (concat (getenv "delpkgbef") "/remember"))
>
> (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
>
> (defvar alpha-mac-font
>  "-apple-courier-medium-r-normal--24-240-72-72-m-240-iso10646-1")
> '(progn
>  (progn
>    (defconst alpha-mac-font-2
>      "-apple-courier-medium-r-normal--*-*-*-*-*-240-*")
>    (set-frame-font alpha-mac-font-2))
>  )
> (set-frame-font alpha-mac-font)
>
> (require 'org-install)
>
> (defvar alpha-org-map (make-sparse-keymap "alpha org map"))
> (define-key global-map [f8] alpha-org-map)
> (define-key alpha-org-map [f8] 'org-remember)             ;c-c r
> (define-key alpha-org-map "o" 'org-open-at-point-global) ;c-c o
>
> (require 'remember-autoloads)
> (org-remember-insinuate)
>
> (setq org-remember-templates
>      `(("conversation" ?c    "* CONVERSATION %U %?\n%i")))
>
> (add-hook 'remember-mode-hook 'delete-other-windows)
> (setf org-remember-backup-directory
>      (getenv "demacsremember"))
> ;;;(setf org-remember-backup-directory nil)
> (add-hook 'org-remember-mode-hook
>          (lambda () (when org-remember-backup-directory
>                       (cd org-remember-backup-directory))))
> (add-hook 'org-remember-mode-hook
>          (lambda ()
>            (define-key org-remember-mode-map
>                "\C-x\C-s" 'org-remember-finalize)
>            ;;i think org-mode-map will override?
>            (define-key org-remember-mode-map
>                "\C-c\C-c" nil)))
>



-- 
Myalgic encephalomyelitis is causing death and severe suffering
worse than MS.  Conflicts of interest are destroying research.
People get the disease at any time permanently.  Do science and
justice matter to you?  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2009-06-26 22:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-25 22:08 bugs in org-remember-backup-directory Samuel Wales
2009-04-30 13:30 ` Carsten Dominik
2009-05-04 17:14   ` Samuel Wales
2009-05-04 17:57     ` Samuel Wales
2009-06-04 14:40       ` Carsten Dominik
2009-06-04 21:29         ` Samuel Wales
2009-06-05  3:59           ` Samuel Wales
2009-06-05  7:00             ` Carsten Dominik
2009-06-18 22:59               ` Samuel Wales
2009-06-26 22:27             ` Samuel Wales

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).