emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fixed lstset where language= wipes out previous definitions
@ 2021-05-28 22:40 Karl Stump
  2021-09-19 13:02 ` Timothy
  0 siblings, 1 reply; 3+ messages in thread
From: Karl Stump @ 2021-05-28 22:40 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Karl Stump

* ox-latex.el (org-latex-src-block): moved (("language" ,lst-lang)) to the head of the list.
This fixes wiping out preceding definitions given in `org-latex-listings-options'.
TINYCHANGE
---
 lisp/ox-latex.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index b9ecf070a..f956c851e 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -3075,13 +3075,13 @@ contextual information."
 	    (concat
 	     (org-latex--make-option-string
 	      (append
-	       lst-opt
+               `(("language" ,lst-lang))
+               lst-opt
 	       (cond
 		((and (not float) (plist-member attributes :float)) nil)
 		((string= "multicolumn" float) '(("float" "*")))
 		((and float (not (assoc "float" lst-opt)))
 		 `(("float" ,(plist-get info :latex-default-figure-position)))))
-	       `(("language" ,lst-lang))
 	       (if label
 		   `(("label" ,(org-latex--label src-block info)))
 		 '(("label" " ")))
-- 
2.31.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fixed lstset where language= wipes out previous definitions
  2021-05-28 22:40 [PATCH] Fixed lstset where language= wipes out previous definitions Karl Stump
@ 2021-09-19 13:02 ` Timothy
  2021-09-26  9:07   ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Timothy @ 2021-09-19 13:02 UTC (permalink / raw)
  To: Karl Stump; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

Hi  Karl,

Thanks for sending in this patch, and sorry it’s taken so long for someone to
get back to you. Would you mind explaining the issue here a bit more? I can’t
see at a glance how preceding definitions are wiped in the current
code.

Karl Stump <karlstump@gmail.com> writes:

> * ox-latex.el (org-latex-src-block): moved ((“language” ,lst-lang)) to the head of the list.
> This fixes wiping out preceding definitions given in `org-latex-listings-options’.
> TINYCHANGE
> —
>  lisp/ox-latex.el | 4 ++–
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff –git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index b9ecf070a..f956c851e 100644
> — a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -3075,13 +3075,13 @@ contextual information.“
>  	    (concat
>  	     (org-latex–make-option-string
>  	      (append
> -	       lst-opt
> +               `((”language“ ,lst-lang))
> +               lst-opt
>  	       (cond
>  		((and (not float) (plist-member attributes :float)) nil)
>  		((string= ”multicolumn“ float) ’((”float“ ”*“)))
>  		((and float (not (assoc ”float“ lst-opt)))
>  		 `((”float“ ,(plist-get info :latex-default-figure-position)))))
> -	       `((”language“ ,lst-lang))
>  	       (if label
>  		   `((”label“ ,(org-latex–label src-block info)))
>  		 ’((”label“ ” “)))

All the best,
Timothy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fixed lstset where language= wipes out previous definitions
  2021-09-19 13:02 ` Timothy
@ 2021-09-26  9:07   ` Bastien
  0 siblings, 0 replies; 3+ messages in thread
From: Bastien @ 2021-09-26  9:07 UTC (permalink / raw)
  To: Karl Stump; +Cc: emacs-orgmode, Timothy

Hi Karl,

can you expand a bit more on why this patch would be useful?  Perhaps
by providing a reproducible use-case where the problem appears?

Thanks,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-26  9:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 22:40 [PATCH] Fixed lstset where language= wipes out previous definitions Karl Stump
2021-09-19 13:02 ` Timothy
2021-09-26  9:07   ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).