From: satotake <firstname.lastname@example.org> To: email@example.com Cc: firstname.lastname@example.org Subject: Re: org-refile.el: Fix test case (Squashed) Date: Fri, 14 May 2021 03:20:51 +0900 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Thank you for your response. > Maybe I have missed something, but it seems 2 > patches are not logically independent, second one touches the same code > to fix regression in tests. > If so, could you, please, squash both > patches into a single one (e.g. using git rebase --interactive)? Yes. They should be a single patch. I squashed them. > Have you tried org-capture? Yes. Mostly I use org-capture, especially, for creating TODO tasks. I sometimes start with fundamental-mode new buffer. After writing some texts, I switch to org-mode and try to call refile. I do not know why I do it by myself clearly but I tend to do it when I do not have any clear goal for the file. I see this issue not critical for now because I know why this happens and just save it anywhere temporarily to avoid it. But when I was new to Emacs and org-mode, I did not have any idea. Thus, at least, we should show friendly error message. > Code around has at least one more problem: questionable behavior in the > case of indirect buffers (e.g. C-x 4 c). Refile targets cache, when > enabled, is not reused for indirect buffer. In addition to your point, I found that we cannot refile internally even with my patch. In other words, if we can cache and reuse it, error ("Please indicate a target file in the refile path") is raised when we select it as refile target. Probably, we need to some additional fixations. It may be good to filter `files' which does not have `buffer-file-name'.
next prev parent reply other threads:[~2021-05-13 18:27 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-09 14:47 org-refile.el: Fix the case of emtpy buffer name satotake 2021-05-09 14:47 ` [PATCH] " satotake 2021-05-09 15:55 ` satotake 2021-05-09 15:55 ` [PATCH 2/2] org-refile.el: Fix test case satotake 2021-05-09 16:05 ` satotake 2021-05-11 11:45 ` Maxim Nikulin 2021-05-13 18:20 ` satotake [this message] 2021-05-13 18:20 ` [PATCH] org-refile.el: Fix the case of emtpy buffer name satotake 2021-05-14 15:09 ` Maxim Nikulin 2021-05-15 8:20 ` Bastien 2021-05-15 10:38 ` satotake 2021-05-15 10:38 ` [PATCH] org-refile.el: Fix the case of *scratch* buffer satotake
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: org-refile.el: Fix test case (Squashed)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).