From: Maxim Nikulin <email@example.com> To: firstname.lastname@example.org Subject: Re: [PATCH 2/2] org-refile.el: Fix test case Date: Tue, 11 May 2021 18:45:34 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 09/05/2021 23:05, satotake wrote: > * lisp/org-refile.el (org-refile-get-targets): Check > `buffer-file-name' return value instead of `buffer-base-buffer'. > > To pass the related tests, we need to check `buffer-file-name'. Thank you for the patches. Maybe I have missed something, but it seems 2 patches are not logically independent, second one touches the same code to fix regression in tests. If so, could you, please, squash both patches into a single one (e.g. using git rebase --interactive)? I hope, it will help to review the change and to avoid confusion with several versions of second patch in 2 threads. Code around has at least one more problem: questionable behavior in the case of indirect buffers (e.g. C-x 4 c). Refile targets cache, when enabled, is not reused for indirect buffer. On 09/05/2021 21:47, satotake wrote: > I often use org-mode for note-taking and so on. > Sometimes, I would like to refile the headings in the scratch to other > org files while I am writing. Have you tried org-capture? https://orgmode.org/manual/Capture.html https://sachachua.com/blog/2015/02/learn-take-notes-efficiently-org-mode/#unnumbered-3 I think, existence of this feature is the reason why this bug was remaining unnoticed.
next prev parent reply other threads:[~2021-05-11 11:47 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-09 14:47 org-refile.el: Fix the case of emtpy buffer name satotake 2021-05-09 14:47 ` [PATCH] " satotake 2021-05-09 15:55 ` satotake 2021-05-09 15:55 ` [PATCH 2/2] org-refile.el: Fix test case satotake 2021-05-09 16:05 ` satotake 2021-05-11 11:45 ` Maxim Nikulin [this message] 2021-05-13 18:20 ` org-refile.el: Fix test case (Squashed) satotake 2021-05-13 18:20 ` [PATCH] org-refile.el: Fix the case of emtpy buffer name satotake 2021-05-14 15:09 ` Maxim Nikulin 2021-05-15 8:20 ` Bastien 2021-05-15 10:38 ` satotake 2021-05-15 10:38 ` [PATCH] org-refile.el: Fix the case of *scratch* buffer satotake 2021-05-09 16:02 [PATCH 2/2] org-refile.el: Fix test case satotake
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com' \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/2] org-refile.el: Fix test case' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).