emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-indent-boundary-char doesn't have org-indent face [9.1.9 (release_9.1.9-65-g5e4542 @ c:/Program Files/emacs-26.1-x86_64/share/emacs/26.1/lisp/org/)]
@ 2018-07-24  1:18 HIRATA Tadashi
  2018-08-21 18:07 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: HIRATA Tadashi @ 2018-07-24  1:18 UTC (permalink / raw)
  To: emacs-orgmode

Hello org-mode developers,

I found a bug that org-indent-boundary-char doens't have
org-indent face property in org-indent-mode. This causes an
appearance issue when you use org-mode with whitespace-mode
that you can't control org-indent-boundary-char's face
neither whitespace-space face nor org-indent face.

Here is a quick patch to fix the problem. (though I test it
in 9.1.9, but it should work well in the latest version).

Sincerely,
Tadashi

------------------------------------------------------------------------

diff -u org-indent.el_org org-indent.el
--- org-indent.el_org	2018-07-23 14:13:06.045078400 +0900
+++ org-indent.el	2018-07-24 10:00:57.898200400 +0900
@@ -150,10 +150,11 @@
       ;; Text line prefixes.
       (aset org-indent--text-line-prefixes
 	    n
-	    (concat (org-add-props (make-string (+ n indentation) ?\s)
-			nil 'face 'org-indent)
-		    (and (> n 0)
-			 (char-to-string org-indent-boundary-char)))))))
+	    (org-add-props 
+		(concat (make-string (+ n indentation) ?\s)
+			(and (> n 0)
+			     (char-to-string org-indent-boundary-char)))
+		nil 'face 'org-indent)))))
 
 (defsubst org-indent-remove-properties (beg end)
   "Remove indentations between BEG and END."

------------------------------------------------------------------------



Emacs  : GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-31
Package: Org mode version 9.1.9 (release_9.1.9-65-g5e4542 @ c:/Program Files/emacs-26.1-x86_64/share/emacs/26.1/lisp/org/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
                     org-src-mode-configure-edit-buffer)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-time-stamp-custom-formats '("<%Y/%m/%d>" . "<%Y/%m/%d %H:%M>")
 org-indent-boundary-char 124
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-show-block-all append
                    local]
                   5]
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-babel-show-result-all
                    append local]
                   5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes
                 (lambda nil (setq truncate-lines nil)
                  (define-key org-mode-map "\346" (quote org-metaright))
                  (define-key org-mode-map "\342" (quote org-metaleft))
                  (define-key org-mode-map "\360" (quote org-metaup))
                  (define-key org-mode-map "\356" (quote org-metadown))
                  (define-key org-mode-map "\306" (quote org-shiftmetaright))
                  (define-key org-mode-map "\302" (quote org-shiftmetaleft))
                  (define-key org-mode-map "\320" (quote org-shiftmetaup))
                  (define-key org-mode-map "\316" (quote org-shiftmetadown))
                  (set-face-foreground (quote org-level-1) "DeepSkyBlue")
                  (set-face-foreground (quote org-level-2) "MediumBlue")
                  (set-face-foreground (quote org-level-3) "DodgerBlue")
                  (set-face-foreground (quote org-level-4) "SlateBlue")
                  (set-face-foreground (quote org-level-5) "LightSeaGreen")
                  (set-face-foreground (quote org-level-6) "DarkGreen")
                  (set-face-foreground (quote org-level-7) "gray40")
                  (set-face-foreground (quote org-level-8) "gray60")
                  (set-face-foreground (quote org-indent) "gray100"))
                 )
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-startup-indented t
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
                      org-babel-header-arg-expand)
 org-hide-leading-stars t
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-separator-lines 0
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
                  org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate
                          org-babel-speed-command-activate)
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("id" :follow org-id-open)
                       ("rmail" :follow org-rmail-open :store
                        org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link)
                       ("info" :follow org-info-open :export org-info-export
                        :store org-info-store-link)
                       ("gnus" :follow org-gnus-open :store
                        org-gnus-store-link)
                       ("docview" :follow org-docview-open :export
                        org-docview-export :store org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store
                        org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export
                        :complete org-bbdb-complete-link :store
                        org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link) ("file+sys")
                       ("file+emacs") ("doi" :follow org--open-doi-link)
                       ("elisp" :follow org--open-elisp-link)
                       ("file" :complete org-file-complete-link)
                       ("ftp" :follow
                        (lambda (path) (browse-url (concat "ftp:" path))))
                       ("help" :follow org--open-help-link)
                       ("http" :follow
                        (lambda (path) (browse-url (concat "http:" path))))
                       ("https" :follow
                        (lambda (path) (browse-url (concat "https:" path))))
                       ("mailto" :follow
                        (lambda (path) (browse-url (concat "mailto:" path))))
                       ("news" :follow
                        (lambda (path) (browse-url (concat "news:" path))))
                       ("shell" :follow org--open-shell-link))
 org-display-custom-times t
 )

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug: org-indent-boundary-char doesn't have org-indent face [9.1.9 (release_9.1.9-65-g5e4542 @ c:/Program Files/emacs-26.1-x86_64/share/emacs/26.1/lisp/org/)]
  2018-07-24  1:18 Bug: org-indent-boundary-char doesn't have org-indent face [9.1.9 (release_9.1.9-65-g5e4542 @ c:/Program Files/emacs-26.1-x86_64/share/emacs/26.1/lisp/org/)] HIRATA Tadashi
@ 2018-08-21 18:07 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2018-08-21 18:07 UTC (permalink / raw)
  To: HIRATA Tadashi; +Cc: emacs-orgmode

Hello,

HIRATA Tadashi <t1-hirata@nri.co.jp> writes:

> I found a bug that org-indent-boundary-char doens't have
> org-indent face property in org-indent-mode. This causes an
> appearance issue when you use org-mode with whitespace-mode
> that you can't control org-indent-boundary-char's face
> neither whitespace-space face nor org-indent face.
>
> Here is a quick patch to fix the problem. (though I test it
> in 9.1.9, but it should work well in the latest version).

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-21 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24  1:18 Bug: org-indent-boundary-char doesn't have org-indent face [9.1.9 (release_9.1.9-65-g5e4542 @ c:/Program Files/emacs-26.1-x86_64/share/emacs/26.1/lisp/org/)] HIRATA Tadashi
2018-08-21 18:07 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).