emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rick Frankel <rick@rickster.com>
To: Rasmus <rasmus@gmx.us>
Cc: bzg@gnu.org, n.goaziou@gmail.com, emacs-orgmode@gnu.org
Subject: Re: [patch][ox-html] Support for level based containers
Date: Mon, 17 Mar 2014 20:33:39 -0400	[thread overview]
Message-ID: <20140318003339.GA92601@eyeBook> (raw)
In-Reply-To: <87d2hk31ij.fsf@gmx.us>

On Mon, Mar 17, 2014 at 11:26:28PM +0100, Rasmus wrote:
> Rick Frankel <rick@rickster.com> writes:
>
> > On Mon, Mar 17, 2014 at 03:15:50AM +0100, Bastien wrote:
> >> Hi Rasmus and Nicolas,
> >>
> >
> >> Nicolas Goaziou <n.goaziou@gmail.com> writes:
> >>
> >> >> Let me know if you find you'd be willing to merge something like this
> >> >
> >> > I don't know enough HTML to have an opinion here.
> >>
> >
> > I don't think it's a bad change, but i have a couple of concerns:
> >
> >     1. It's a breaking change.
> >     2. The default should mimic the current functionality:
> >        ='((div . div))=
> >     3. The customization should be more structured, not just a
> >        string (see e.g., =org-html-text-markup-alist=.)
> >
> > Attached is a modification of the patch which fixes 2 & 3. #1 is a
> > question more for Nicolas & Bastien...
>
> It seems you modified v1 rather than v2 that I send last night¹?  I'm
> not sure if point 1 holds in the second revision as it explicitly
> allows for a string as now. I think I disagree with your point 2 as it
> only shows up when you use HTML5-fancy.  On point 3,

But not everyone using html5-fancy would agree with your choice of
hierarchy, and it should be up to indvidual users to add additional
semantic structure to the output.

> org-html-text-markup-alist is nice.  What do you want to see in
> addition to the current structure (in patch v2)?

Somehow I never saw the original thread, only the email cc'ing me
directly. I went to gmane to find the patch, and obviously grabbed the
wrong one.

Could you please send me the (new) patch so that i can review it?

thanx,
rick

  reply	other threads:[~2014-03-18  0:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-15 23:18 [patch][ox-html] Support for level based containers Rasmus
2014-03-16 13:10 ` Nicolas Goaziou
2014-03-17  0:30   ` Rasmus
2014-03-17  2:15   ` Bastien
2014-03-17 17:31     ` Rick Frankel
2014-03-17 22:26       ` Rasmus
2014-03-18  0:33         ` Rick Frankel [this message]
2014-03-18  3:31           ` Rasmus
2014-03-18 15:05             ` Rick Frankel
2014-03-18 19:41               ` Rasmus
2014-03-19 14:24                 ` Rick Frankel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318003339.GA92601@eyeBook \
    --to=rick@rickster.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).