From: Suvayu Ali <fatkasuvayu+linux@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: C-u C-u C-c ! inserts an active timestamp.
Date: Mon, 23 Sep 2013 16:08:25 +0200 [thread overview]
Message-ID: <20130923140825.GE26926@kuru.dyndns-at-home.com> (raw)
In-Reply-To: <86ob7jdhjq.fsf@somewhere.org>
On Mon, Sep 23, 2013 at 11:16:25AM +0200, Sebastien Vauban wrote:
> Hello Suvayu,
>
> Suvayu Ali wrote:
> > On Mon, Sep 23, 2013 at 10:51:33AM +0200, Nicolas Richard wrote:
> >> Carsten Dominik <carsten.dominik@gmail.com> writes:
> >>
> >> > Applied
> >>
> >> I noticed that the whole mail went into the commit msg (commit
> >> 12de6223dcd736c0958eca874def052b407ff5d1) ; did I send the patch
> >> incorrectly ?
> >>
> >> I used git format-patch then inserted the result at the end of the email
> >> I wrote. The page http://orgmode.org/worg/org-contribute.html#sec-4 is
> >> not very explicit about how to send the result of `git format-patch',
> >> but I seem to remember it was ok to just yank the content at the end of
> >> a mail. Is that a wrong assumption ?
> >
> > Simply attaching the patch as a text attachment should do fine I think.
>
> Though, many guidelines tell:
>
> Do not attach your patch, but submit it "inline" in the mail body,
> /unless you cannot teach your mailer to leave the formatting
> of the patch alone/.
>
> That allows for easy reviews... and easy comments (after every chunk of code).
Valid point. In that case maybe the problem was Nicolas's patch was
inlined after the signature marker, "-- ".
--
Suvayu
Open source is the future. It sets us free.
prev parent reply other threads:[~2013-09-23 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 13:42 C-u C-u C-c ! inserts an active timestamp Nicolas Richard
2013-09-22 6:00 ` Carsten Dominik
2013-09-23 8:51 ` Nicolas Richard
2013-09-23 9:07 ` Suvayu Ali
2013-09-23 9:16 ` Sebastien Vauban
2013-09-23 14:08 ` Suvayu Ali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923140825.GE26926@kuru.dyndns-at-home.com \
--to=fatkasuvayu+linux@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).