From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suvayu Ali Subject: Re: C-u C-u C-c ! inserts an active timestamp. Date: Mon, 23 Sep 2013 16:08:25 +0200 Message-ID: <20130923140825.GE26926@kuru.dyndns-at-home.com> References: <87li2wvq66.fsf@yahoo.fr> <6D83857C-F40D-4490-9503-DF16D5A3177D@gmail.com> <87mwn3gbu2.fsf@yahoo.fr> <20130923090709.GA26926@kuru.dyndns-at-home.com> <86ob7jdhjq.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6oV-00039I-CW for emacs-orgmode@gnu.org; Mon, 23 Sep 2013 10:08:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO6oT-0008Df-Vj for emacs-orgmode@gnu.org; Mon, 23 Sep 2013 10:08:35 -0400 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:46601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO6oT-0008DM-ML for emacs-orgmode@gnu.org; Mon, 23 Sep 2013 10:08:33 -0400 Received: by mail-ea0-f180.google.com with SMTP id h10so1725328eaj.39 for ; Mon, 23 Sep 2013 07:08:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <86ob7jdhjq.fsf@somewhere.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org On Mon, Sep 23, 2013 at 11:16:25AM +0200, Sebastien Vauban wrote: > Hello Suvayu, > > Suvayu Ali wrote: > > On Mon, Sep 23, 2013 at 10:51:33AM +0200, Nicolas Richard wrote: > >> Carsten Dominik writes: > >> > >> > Applied > >> > >> I noticed that the whole mail went into the commit msg (commit > >> 12de6223dcd736c0958eca874def052b407ff5d1) ; did I send the patch > >> incorrectly ? > >> > >> I used git format-patch then inserted the result at the end of the email > >> I wrote. The page http://orgmode.org/worg/org-contribute.html#sec-4 is > >> not very explicit about how to send the result of `git format-patch', > >> but I seem to remember it was ok to just yank the content at the end of > >> a mail. Is that a wrong assumption ? > > > > Simply attaching the patch as a text attachment should do fine I think. > > Though, many guidelines tell: > > Do not attach your patch, but submit it "inline" in the mail body, > /unless you cannot teach your mailer to leave the formatting > of the patch alone/. > > That allows for easy reviews... and easy comments (after every chunk of code). Valid point. In that case maybe the problem was Nicolas's patch was inlined after the signature marker, "-- ". -- Suvayu Open source is the future. It sets us free.