emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* C-o now mapped to org-ctrl-o surprise
@ 2013-04-13 21:28 Sean O'Halpin
  2013-04-14  8:31 ` Bastien
  2013-04-14 23:24 ` Suvayu Ali
  0 siblings, 2 replies; 4+ messages in thread
From: Sean O'Halpin @ 2013-04-13 21:28 UTC (permalink / raw)
  To: Org Mode

Hi,

I was quite surprised after pulling down master to find that C-o has
been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200).

I personally don't use open-line much myself so remap this key for my own use.

Wouldn't it be better to do something like:

    (define-key org-mode-map [remap open-line] 'org-ctrl-o)

and let the user choose which key does open-line rather than create a
new keybinding which might override a user definition? Also, perhaps
the function should be called org-open-line rather than org-ctrl-o.

Regards,
Sean

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: C-o now mapped to org-ctrl-o surprise
  2013-04-13 21:28 C-o now mapped to org-ctrl-o surprise Sean O'Halpin
@ 2013-04-14  8:31 ` Bastien
  2013-04-14 11:22   ` Sean O'Halpin
  2013-04-14 23:24 ` Suvayu Ali
  1 sibling, 1 reply; 4+ messages in thread
From: Bastien @ 2013-04-14  8:31 UTC (permalink / raw)
  To: Sean O'Halpin; +Cc: Org Mode

Hi Sean,

"Sean O'Halpin" <sean.ohalpin@gmail.com> writes:

> I was quite surprised after pulling down master to find that C-o has
> been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200).
>
> I personally don't use open-line much myself so remap this key for my own use.
>
> Wouldn't it be better to do something like:
>
>     (define-key org-mode-map [remap open-line] 'org-ctrl-o)
>
> and let the user choose which key does open-line rather than create a
> new keybinding which might override a user definition? Also, perhaps
> the function should be called org-open-line rather than org-ctrl-o.

Indeed.  I renamed the command and used remap as you suggest.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: C-o now mapped to org-ctrl-o surprise
  2013-04-14  8:31 ` Bastien
@ 2013-04-14 11:22   ` Sean O'Halpin
  0 siblings, 0 replies; 4+ messages in thread
From: Sean O'Halpin @ 2013-04-14 11:22 UTC (permalink / raw)
  To: Bastien; +Cc: Org Mode

Gosh, that was quick!

Thanks,
Sean


On Sun, Apr 14, 2013 at 9:31 AM, Bastien <bzg@gnu.org> wrote:
> Hi Sean,
>
> "Sean O'Halpin" <sean.ohalpin@gmail.com> writes:
>
>> I was quite surprised after pulling down master to find that C-o has
>> been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200).
>>
>> I personally don't use open-line much myself so remap this key for my own use.
>>
>> Wouldn't it be better to do something like:
>>
>>     (define-key org-mode-map [remap open-line] 'org-ctrl-o)
>>
>> and let the user choose which key does open-line rather than create a
>> new keybinding which might override a user definition? Also, perhaps
>> the function should be called org-open-line rather than org-ctrl-o.
>
> Indeed.  I renamed the command and used remap as you suggest.
>
> --
>  Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: C-o now mapped to org-ctrl-o surprise
  2013-04-13 21:28 C-o now mapped to org-ctrl-o surprise Sean O'Halpin
  2013-04-14  8:31 ` Bastien
@ 2013-04-14 23:24 ` Suvayu Ali
  1 sibling, 0 replies; 4+ messages in thread
From: Suvayu Ali @ 2013-04-14 23:24 UTC (permalink / raw)
  To: emacs-orgmode

On Sat, Apr 13, 2013 at 10:28:30PM +0100, Sean O'Halpin wrote:
> Hi,
> 
> I was quite surprised after pulling down master to find that C-o has
> been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200).
> 
> I personally don't use open-line much myself so remap this key for my own use.
> 
> Wouldn't it be better to do something like:
> 
>     (define-key org-mode-map [remap open-line] 'org-ctrl-o)
> 
> and let the user choose which key does open-line rather than create a
> new keybinding which might override a user definition? Also, perhaps
> the function should be called org-open-line rather than org-ctrl-o.

I would agree too.  I think there are few other instances of this kind
of remappings; can't recall which though.

-- 
Suvayu

Open source is the future. It sets us free.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-14 23:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-13 21:28 C-o now mapped to org-ctrl-o surprise Sean O'Halpin
2013-04-14  8:31 ` Bastien
2013-04-14 11:22   ` Sean O'Halpin
2013-04-14 23:24 ` Suvayu Ali

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).