From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: C-o now mapped to org-ctrl-o surprise Date: Sun, 14 Apr 2013 10:31:34 +0200 Message-ID: <87ppxxa1f5.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URJY4-0007r5-B9 for emacs-orgmode@gnu.org; Sun, 14 Apr 2013 05:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URJY3-0003TN-HP for emacs-orgmode@gnu.org; Sun, 14 Apr 2013 05:48:36 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:39956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URJY3-0003T6-Av for emacs-orgmode@gnu.org; Sun, 14 Apr 2013 05:48:35 -0400 Received: by mail-wg0-f54.google.com with SMTP id y10so617796wgg.21 for ; Sun, 14 Apr 2013 02:48:33 -0700 (PDT) In-Reply-To: (Sean O'Halpin's message of "Sat, 13 Apr 2013 22:28:30 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sean O'Halpin Cc: Org Mode Hi Sean, "Sean O'Halpin" writes: > I was quite surprised after pulling down master to find that C-o has > been bound to org-ctrl-o (commit 45d6d8f8 2013-04-05 11:14:20 +0200). > > I personally don't use open-line much myself so remap this key for my own use. > > Wouldn't it be better to do something like: > > (define-key org-mode-map [remap open-line] 'org-ctrl-o) > > and let the user choose which key does open-line rather than create a > new keybinding which might override a user definition? Also, perhaps > the function should be called org-open-line rather than org-ctrl-o. Indeed. I renamed the command and used remap as you suggest. -- Bastien