* Needless opening of threads in org-wl
@ 2008-09-20 10:05 Dhruv Bansal
0 siblings, 0 replies; 3+ messages in thread
From: Dhruv Bansal @ 2008-09-20 10:05 UTC (permalink / raw)
To: emacs-orgmode
I like to link to Wanderlust emails from Org Mode. I just downloaded
the latest git version and linking to WL emails works as advertised
except that I wind up sitting for five minutes as every thread in my
13,000 message inbox is opened. Is there a reason for this behavior?
I "fixed" the problem with the following patch which merely comments
out the command to open all the threads. Linking emails works
perfectly fine and now I don't have to wait long at all.
================
diff --git a/lisp/org-wl.el b/lisp/org-wl.el
index 4fae584..58ddd31 100644
--- a/lisp/org-wl.el
+++ b/lisp/org-wl.el
@@ -135,7 +135,7 @@
;; in the old buffer.
(set-buffer old-buf)
(goto-char old-point))
- (wl-thread-open-all)
+; (wl-thread-open-all)
(and (wl-summary-jump-to-msg-by-message-id (org-add-angle-brackets
article))
(wl-summary-redisplay)))))
================
Just thought I'd post this in case anyone else was similarly
frustrated.
I'm excited about the new org version; thanks so much everyone for
helping to create such a great application!
--
Dhruv Bansal
http://www.dhruvbansal.com
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Needless opening of threads in org-wl
@ 2008-09-27 15:33 Tokuya Kameshima
2008-09-27 15:57 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Tokuya Kameshima @ 2008-09-27 15:33 UTC (permalink / raw)
To: emacs-orgmode; +Cc: kames
Dhruv,
Thank you for the report.
The line of (wl-thread-open-all) is needless. I completely forgot to
remove it.
Carsten,
Could you remove the line of (wl-thread-open-all) from org-wl.el and
update the git repository?
-*-*-
In my initial implementation of org-wl.el, `org-wl-open' was able to
jump to the message by the message number ([[wl:folder#number]]) as
well as by the message id ([[wl:folder#msgid]]). To jump to the
message by the number, the message line had to be shown in the summary
buffer. So I added the code to show all the message lines in the
summary buffer.
The current version of org-wl.el does not support the link with the
message number such as [[wl:folder#number]].
Thanks,
--Tokuya
> From: Dhruv Bansal <lasnabvurhd <at> gmail.com>
> Subject: Needless opening of threads in org-wl
> Newsgroups: gmane.emacs.orgmode
> Date: 2008-09-20 10:05:12 GMT (5 days, 13 hours and 37 minutes ago)
>
> I like to link to Wanderlust emails from Org Mode. I just downloaded
> the latest git version and linking to WL emails works as advertised
> except that I wind up sitting for five minutes as every thread in my
> 13,000 message inbox is opened. Is there a reason for this behavior?
>
> I "fixed" the problem with the following patch which merely comments
> out the command to open all the threads. Linking emails works
> perfectly fine and now I don't have to wait long at all.
>
> ================
> diff --git a/lisp/org-wl.el b/lisp/org-wl.el
> index 4fae584..58ddd31 100644
> --- a/lisp/org-wl.el
> +++ b/lisp/org-wl.el
> @@ -135,7 +135,7 @@
> ;; in the old buffer.
> (set-buffer old-buf)
> (goto-char old-point))
> - (wl-thread-open-all)
> +; (wl-thread-open-all)
> (and (wl-summary-jump-to-msg-by-message-id (org-add-angle-brackets
> article))
> (wl-summary-redisplay)))))
> ================
>
> Just thought I'd post this in case anyone else was similarly
> frustrated.
>
> I'm excited about the new org version; thanks so much everyone for
> helping to create such a great application!
>
> --
> Dhruv Bansal
> http://www.dhruvbansal.com
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode <at> gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: Needless opening of threads in org-wl
2008-09-27 15:33 Needless opening of threads in org-wl Tokuya Kameshima
@ 2008-09-27 15:57 ` Carsten Dominik
0 siblings, 0 replies; 3+ messages in thread
From: Carsten Dominik @ 2008-09-27 15:57 UTC (permalink / raw)
To: Tokuya Kameshima, Dhruv Bansal; +Cc: emacs-orgmode Mailinglist
Hi Tokuya,
thanks a lot for looking into this.
Hi Dhruv,
thank you for fixing this bug.
I have pushed the corresponding fix.
- Carsten
On Sep 27, 2008, at 5:33 PM, Tokuya Kameshima wrote:
> Dhruv,
> Thank you for the report.
>
> The line of (wl-thread-open-all) is needless. I completely forgot to
> remove it.
>
> Carsten,
>
> Could you remove the line of (wl-thread-open-all) from org-wl.el and
> update the git repository?
>
> -*-*-
>
> In my initial implementation of org-wl.el, `org-wl-open' was able to
> jump to the message by the message number ([[wl:folder#number]]) as
> well as by the message id ([[wl:folder#msgid]]). To jump to the
> message by the number, the message line had to be shown in the summary
> buffer. So I added the code to show all the message lines in the
> summary buffer.
>
> The current version of org-wl.el does not support the link with the
> message number such as [[wl:folder#number]].
>
> Thanks,
> --Tokuya
>
>
>> From: Dhruv Bansal <lasnabvurhd <at> gmail.com>
>> Subject: Needless opening of threads in org-wl
>> Newsgroups: gmane.emacs.orgmode
>> Date: 2008-09-20 10:05:12 GMT (5 days, 13 hours and 37 minutes ago)
>>
>> I like to link to Wanderlust emails from Org Mode. I just downloaded
>> the latest git version and linking to WL emails works as advertised
>> except that I wind up sitting for five minutes as every thread in my
>> 13,000 message inbox is opened. Is there a reason for this behavior?
>>
>> I "fixed" the problem with the following patch which merely comments
>> out the command to open all the threads. Linking emails works
>> perfectly fine and now I don't have to wait long at all.
>>
>> ================
>> diff --git a/lisp/org-wl.el b/lisp/org-wl.el
>> index 4fae584..58ddd31 100644
>> --- a/lisp/org-wl.el
>> +++ b/lisp/org-wl.el
>> @@ -135,7 +135,7 @@
>> ;; in the old buffer.
>> (set-buffer old-buf)
>> (goto-char old-point))
>> - (wl-thread-open-all)
>> +; (wl-thread-open-all)
>> (and (wl-summary-jump-to-msg-by-message-id (org-add-angle-
>> brackets
>> article))
>> (wl-summary-redisplay)))))
>> ================
>>
>> Just thought I'd post this in case anyone else was similarly
>> frustrated.
>>
>> I'm excited about the new org version; thanks so much everyone for
>> helping to create such a great application!
>>
>> --
>> Dhruv Bansal
>> http://www.dhruvbansal.com
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode <at> gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-27 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-27 15:33 Needless opening of threads in org-wl Tokuya Kameshima
2008-09-27 15:57 ` Carsten Dominik
-- strict thread matches above, loose matches on Subject: below --
2008-09-20 10:05 Dhruv Bansal
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).