emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Re: Patch for problem with xemacs
  2008-12-08 21:47 Patch for problem with xemacs Thomas Fuchs
@ 2008-12-08 20:58 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2008-12-08 20:58 UTC (permalink / raw)
  To: Thomas Fuchs; +Cc: emacs-orgmode

Hi Thomas,

thanks for the analysis, I have applied a simplified version of your  
patch.

- Carsten

On Dec 8, 2008, at 10:47 PM, Thomas Fuchs wrote:

>
> Hi there!
>
> The function org-substring-no-properties is called in org-remember.el
> with one argument and defined with one plus two optional arguments. In
> case of xemacs the function delegates to substring which requires
> a non-optional second argument "from".
>
> The attached patch handles this.
>
> Greetings
> Thomas
>
> <patch>_______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Patch for problem with xemacs
@ 2008-12-08 21:47 Thomas Fuchs
  2008-12-08 20:58 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Fuchs @ 2008-12-08 21:47 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 312 bytes --]


Hi there!

The function org-substring-no-properties is called in org-remember.el
with one argument and defined with one plus two optional arguments. In
case of xemacs the function delegates to substring which requires 
a non-optional second argument "from".

The attached patch handles this.

Greetings
Thomas


[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 466 bytes --]

diff --git a/lisp/org-compat.el b/lisp/org-compat.el
index 08f66fc..197fcbb 100644
--- a/lisp/org-compat.el
+++ b/lisp/org-compat.el
@@ -284,7 +284,7 @@ that can be added."
 
 (defun org-substring-no-properties (string &optional from to)
   (if (featurep 'xemacs)
-      (org-no-properties (substring string from to))
+      (org-no-properties (substring string (if (eq from nil) 0 from) to))
     (substring-no-properties string from to)))
 
 (provide 'org-compat)

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-08 20:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-08 21:47 Patch for problem with xemacs Thomas Fuchs
2008-12-08 20:58 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).