* Org errors when requiring a new pabbrev.el version
@ 2007-11-04 12:29 Tassilo Horn
2007-11-04 13:39 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Tassilo Horn @ 2007-11-04 12:29 UTC (permalink / raw)
To: emacs-orgmode
Hi,
in <uk5p1r61m.fsf@newcastle.ac.uk> Phillip Lord posted a new version oy
his pabbrev.el in the emacs-sources mailinglist. There seem to be some
changes that break the current code in org.el. When I do (require
'pabbrev) I get.
--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (void-variable pabbrev-expand-after-command-list)
add-to-list(pabbrev-expand-after-command-list orgtbl-self-insert-command t)
(progn (add-to-list (quote pabbrev-expand-after-command-list) (quote orgtbl-self-insert-command) t) (add-to-list (quote pabbrev-expand-after-command-list) (quote org-self-insert-command) t))
eval((progn (add-to-list (quote pabbrev-expand-after-command-list) (quote orgtbl-self-insert-command) t) (add-to-list (quote pabbrev-expand-after-command-list) (quote org-self-insert-command) t)))
do-after-load-evaluation("/home/heimdall/elisp/pabbrev.el")
load-with-code-conversion("/home/heimdall/elisp/pabbrev.el" "/home/heimdall/elisp/pabbrev.el" nil t)
require(pabbrev)
eval((require (quote pabbrev)))
eval-last-sexp-1(nil)
eval-last-sexp(nil)
call-interactively(eval-last-sexp)
--8<---------------cut here---------------end--------------->8---
The corresponding code in org.el is
--8<---------------cut here---------------start------------->8---
(eval-after-load "pabbrev"
'(progn
(add-to-list 'pabbrev-expand-after-command-list
'orgtbl-self-insert-command t)
(add-to-list 'pabbrev-expand-after-command-list
'org-self-insert-command t)))
--8<---------------cut here---------------end--------------->8---
It seems the variable name has been changed. This is what the comments
of pabbrev.el say.
--8<---------------cut here---------------start------------->8---
;;; Package Support:
;;
;; Some packages need extra support for pabbrev to work with. There are two
;; plists properties which package developers can use.
;;
;; (put 'command-name 'pabbrev-expand-after-command t)
;;
;; means that the following the named command (in this case command-name),
;; expansion will be offered. `self-insert-command' and a few others is
;; normally fine, but not always.
;;
;; (put mode-name 'pabbrev-global-mode-excluded-modes t)
;;
;; will mean that any buffer with this major mode will not have
;; global-pabbrev-mode activated.
;;
--8<---------------cut here---------------end--------------->8---
Bye,
Tassilo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Org errors when requiring a new pabbrev.el version
2007-11-04 12:29 Org errors when requiring a new pabbrev.el version Tassilo Horn
@ 2007-11-04 13:39 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2007-11-04 13:39 UTC (permalink / raw)
To: Tassilo Horn; +Cc: emacs-orgmode
Hi Tassilo,
yes, thanks for the correct analysis.
Phillip changed pabbrev.el on my request, to improve package support.
Org-mode 5.14 will then work correctly with pabbrev.el.
For now, just use this hack in .emacs (remove again after
the 5.14 release):
;; Create this obsolete variable, to keep org.el <5.14 from hitting
an error
(defvar pabbrev-expand-after-command-list nil)
;; Make pabbrev-mode expand after org-mode commands
(put 'org-self-insert-command 'pabbrev-expand-after-command t)
(put 'orgybl-self-insert-command 'pabbrev-expand-after-command t)
- Carsten
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-04 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-04 12:29 Org errors when requiring a new pabbrev.el version Tassilo Horn
2007-11-04 13:39 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).