* [PATCH] org-clock: Customizable variable syntax fix
@ 2012-05-30 5:35 Tim Howe
2012-07-10 9:15 ` [Accepted] " Bastien Guerry
0 siblings, 1 reply; 2+ messages in thread
From: Tim Howe @ 2012-05-30 5:35 UTC (permalink / raw)
To: emacs-orgmode
* org-clock.el (org-clocktable-defaults): Revert extra layer of quoting.
It appears the goal in 9b23f082 was to allow defaulting a plist member
to a variable; however the plist was being constructed with LIST and
therefore the `, combination was unnecessary.
TINYCHANGE
---
lisp/org-clock.el | 40 ++++++++++++++++++++--------------------
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 70c015b..fe3e154 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -248,26 +248,26 @@ string as argument."
:group 'org-clock)
(defcustom org-clocktable-defaults
- `(list
- :maxlevel 2
- :lang ,org-export-default-language
- :scope 'file
- :block nil
- :tstart nil
- :tend nil
- :step nil
- :stepskip0 nil
- :fileskip0 nil
- :tags nil
- :emphasize nil
- :link nil
- :narrow '40!
- :indent t
- :formula nil
- :timestamp nil
- :level nil
- :tcolumns nil
- :formatter nil)
+ (list
+ :maxlevel 2
+ :lang org-export-default-language
+ :scope 'file
+ :block nil
+ :tstart nil
+ :tend nil
+ :step nil
+ :stepskip0 nil
+ :fileskip0 nil
+ :tags nil
+ :emphasize nil
+ :link nil
+ :narrow '40!
+ :indent t
+ :formula nil
+ :timestamp nil
+ :level nil
+ :tcolumns nil
+ :formatter nil)
"Default properties for clock tables."
:group 'org-clock
:version "24.1"
--
1.7.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Accepted] org-clock: Customizable variable syntax fix
2012-05-30 5:35 [PATCH] org-clock: Customizable variable syntax fix Tim Howe
@ 2012-07-10 9:15 ` Bastien Guerry
0 siblings, 0 replies; 2+ messages in thread
From: Bastien Guerry @ 2012-07-10 9:15 UTC (permalink / raw)
To: emacs-orgmode
Patch 1343 (http://patchwork.newartisans.com/patch/1343/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C1338356138-18503-1-git-send-email-vsync%40quadium.net%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] org-clock: Customizable variable syntax fix
> Date: Wed, 30 May 2012 10:35:38 -0000
> From: Tim Howe <vsync@quadium.net>
> X-Patchwork-Id: 1343
> Message-Id: <1338356138-18503-1-git-send-email-vsync@quadium.net>
> To: emacs-orgmode@gnu.org
>
> * org-clock.el (org-clocktable-defaults): Revert extra layer of quoting.
>
> It appears the goal in 9b23f082 was to allow defaulting a plist member
> to a variable; however the plist was being constructed with LIST and
> therefore the `, combination was unnecessary.
>
> TINYCHANGE
>
> ---
> lisp/org-clock.el | 40 ++++++++++++++++++++--------------------
> 1 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 70c015b..fe3e154 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -248,26 +248,26 @@ string as argument."
> :group 'org-clock)
>
> (defcustom org-clocktable-defaults
> - `(list
> - :maxlevel 2
> - :lang ,org-export-default-language
> - :scope 'file
> - :block nil
> - :tstart nil
> - :tend nil
> - :step nil
> - :stepskip0 nil
> - :fileskip0 nil
> - :tags nil
> - :emphasize nil
> - :link nil
> - :narrow '40!
> - :indent t
> - :formula nil
> - :timestamp nil
> - :level nil
> - :tcolumns nil
> - :formatter nil)
> + (list
> + :maxlevel 2
> + :lang org-export-default-language
> + :scope 'file
> + :block nil
> + :tstart nil
> + :tend nil
> + :step nil
> + :stepskip0 nil
> + :fileskip0 nil
> + :tags nil
> + :emphasize nil
> + :link nil
> + :narrow '40!
> + :indent t
> + :formula nil
> + :timestamp nil
> + :level nil
> + :tcolumns nil
> + :formatter nil)
> "Default properties for clock tables."
> :group 'org-clock
> :version "24.1"
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-10 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-30 5:35 [PATCH] org-clock: Customizable variable syntax fix Tim Howe
2012-07-10 9:15 ` [Accepted] " Bastien Guerry
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).