* PATCH[3/3]: org-element.el: Remove illegal t clause in case
@ 2012-08-30 7:56 Michael Sperber
2012-08-30 8:28 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Michael Sperber @ 2012-08-30 7:56 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but
we think it's a bug on GNU Emacs, too.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-org-element.el-Remove-illegal-t-clause-in-case.patch --]
[-- Type: text/x-patch, Size: 997 bytes --]
From 516456845f93d2ef7f05c6f7789f8ff4e368f6f6 Mon Sep 17 00:00:00 2001
From: Mats Lidell <matsl@xemacs.org>
Date: Sun, 26 Aug 2012 22:24:15 +0200
Subject: [PATCH 3/3] org-element.el: Remove illegal t clause in case
* lisp/org-element.el (org-element-paragraph-separate): Remove illegal
t clause in case.
---
lisp/org-element.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org-element.el b/lisp/org-element.el
index 3bf217d..4aeb74c 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -149,7 +149,7 @@
"\\|"
;; Lists.
(let ((term (case org-plain-list-ordered-item-terminator
- (t "[.)]") (?\) ")") (?. "\\.") (otherwise "[.)]")))
+ (?\) ")") (?. "\\.") (otherwise "[.)]")))
(alpha (and org-alphabetical-lists "\\|[A-Za-z]")))
(concat "\\(?:[-+*]\\|\\(?:[0-9]+" alpha "\\)" term "\\)"
"\\(?:[ \t]\\|$\\)"))
--
1.7.0.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: PATCH[3/3]: org-element.el: Remove illegal t clause in case
2012-08-30 7:56 PATCH[3/3]: org-element.el: Remove illegal t clause in case Michael Sperber
@ 2012-08-30 8:28 ` Bastien
2012-08-30 9:04 ` Michael Sperber
0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2012-08-30 8:28 UTC (permalink / raw)
To: Michael Sperber; +Cc: Mats Lidell, emacs-orgmode
Hi Michael and Mats,
Michael Sperber <sperber@deinprogramm.de> writes:
> This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but
> we think it's a bug on GNU Emacs, too.
Thank you both for the patch! I just applied it.
I changed the commit log. At least in GNU Emacs, t is allowed,
but only as the last clause.
See the docstring of `case':
[...]
A KEYLIST of t or `otherwise' is
allowed only in the final clause, and matches if no other keys match.
Key values are compared by `eql'.
I guess this is the same for XEmacs, would be strange otherwise.
Best,
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH[3/3]: org-element.el: Remove illegal t clause in case
2012-08-30 8:28 ` Bastien
@ 2012-08-30 9:04 ` Michael Sperber
2012-08-30 20:53 ` Mats Lidell
0 siblings, 1 reply; 4+ messages in thread
From: Michael Sperber @ 2012-08-30 9:04 UTC (permalink / raw)
To: Bastien; +Cc: Mats Lidell, emacs-orgmode
Bastien <bzg@altern.org> writes:
> Hi Michael and Mats,
>
> Michael Sperber <sperber@deinprogramm.de> writes:
>
>> This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but
>> we think it's a bug on GNU Emacs, too.
>
> Thank you both for the patch! I just applied it.
>
> I changed the commit log. At least in GNU Emacs, t is allowed,
> but only as the last clause.
>
> See the docstring of `case':
>
> [...]
> A KEYLIST of t or `otherwise' is
> allowed only in the final clause, and matches if no other keys match.
> Key values are compared by `eql'.
>
> I guess this is the same for XEmacs, would be strange otherwise.
Yup, you're right.
Thanks for applying the patches.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH[3/3]: org-element.el: Remove illegal t clause in case
2012-08-30 9:04 ` Michael Sperber
@ 2012-08-30 20:53 ` Mats Lidell
0 siblings, 0 replies; 4+ messages in thread
From: Mats Lidell @ 2012-08-30 20:53 UTC (permalink / raw)
To: Michael Sperber; +Cc: Bastien, emacs-orgmode
>>>>> Michael Sperber <sperber@deinprogramm.de> writes:
>> I guess this is the same for XEmacs, would be strange otherwise.
> Yup, you're right.
Good catch. I was trying to say it was illegal at that place, it must
be the last clause as you say, but I didn't get the wording
right. Thanks for correcting this!
Yours
--
%% Mats
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-30 20:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-30 7:56 PATCH[3/3]: org-element.el: Remove illegal t clause in case Michael Sperber
2012-08-30 8:28 ` Bastien
2012-08-30 9:04 ` Michael Sperber
2012-08-30 20:53 ` Mats Lidell
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).