[-- Attachment #1: Type: text/plain, Size: 184 bytes --] This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but we think it's a bug on GNU Emacs, too. -- Cheers =8-} Mike Friede, Völkerverständigung und überhaupt blabla [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0003-org-element.el-Remove-illegal-t-clause-in-case.patch --] [-- Type: text/x-patch, Size: 997 bytes --] From 516456845f93d2ef7f05c6f7789f8ff4e368f6f6 Mon Sep 17 00:00:00 2001 From: Mats Lidell <matsl@xemacs.org> Date: Sun, 26 Aug 2012 22:24:15 +0200 Subject: [PATCH 3/3] org-element.el: Remove illegal t clause in case * lisp/org-element.el (org-element-paragraph-separate): Remove illegal t clause in case. --- lisp/org-element.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/org-element.el b/lisp/org-element.el index 3bf217d..4aeb74c 100644 --- a/lisp/org-element.el +++ b/lisp/org-element.el @@ -149,7 +149,7 @@ "\\|" ;; Lists. (let ((term (case org-plain-list-ordered-item-terminator - (t "[.)]") (?\) ")") (?. "\\.") (otherwise "[.)]"))) + (?\) ")") (?. "\\.") (otherwise "[.)]"))) (alpha (and org-alphabetical-lists "\\|[A-Za-z]"))) (concat "\\(?:[-+*]\\|\\(?:[0-9]+" alpha "\\)" term "\\)" "\\(?:[ \t]\\|$\\)")) -- 1.7.0.5
Hi Michael and Mats,
Michael Sperber <sperber@deinprogramm.de> writes:
> This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but
> we think it's a bug on GNU Emacs, too.
Thank you both for the patch! I just applied it.
I changed the commit log. At least in GNU Emacs, t is allowed,
but only as the last clause.
See the docstring of `case':
[...]
A KEYLIST of t or `otherwise' is
allowed only in the final clause, and matches if no other keys match.
Key values are compared by `eql'.
I guess this is the same for XEmacs, would be strange otherwise.
Best,
--
Bastien
Bastien <bzg@altern.org> writes:
> Hi Michael and Mats,
>
> Michael Sperber <sperber@deinprogramm.de> writes:
>
>> This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but
>> we think it's a bug on GNU Emacs, too.
>
> Thank you both for the patch! I just applied it.
>
> I changed the commit log. At least in GNU Emacs, t is allowed,
> but only as the last clause.
>
> See the docstring of `case':
>
> [...]
> A KEYLIST of t or `otherwise' is
> allowed only in the final clause, and matches if no other keys match.
> Key values are compared by `eql'.
>
> I guess this is the same for XEmacs, would be strange otherwise.
Yup, you're right.
Thanks for applying the patches.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
>>>>> Michael Sperber <sperber@deinprogramm.de> writes: >> I guess this is the same for XEmacs, would be strange otherwise. > Yup, you're right. Good catch. I was trying to say it was illegal at that place, it must be the last clause as you say, but I didn't get the wording right. Thanks for correcting this! Yours -- %% Mats