From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Moreton Subject: Re: Bug: Bug in svg generation from plantuml sources [9.1.7 (9.1.7-20-ge1f1ac-elpa @ /home/guertler/.emacs.d/elpa/org-20180319/)] Date: Tue, 20 Mar 2018 16:16:39 +0000 Message-ID: References: <878tan2dn7.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyJwU-0000vs-JR for emacs-orgmode@gnu.org; Tue, 20 Mar 2018 12:16:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyJwR-0008JZ-35 for emacs-orgmode@gnu.org; Tue, 20 Mar 2018 12:16:54 -0400 Received: from [195.159.176.226] (port=46974 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyJwQ-0008FP-SM for emacs-orgmode@gnu.org; Tue, 20 Mar 2018 12:16:51 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eyJuJ-0007zH-W5 for emacs-orgmode@gnu.org; Tue, 20 Mar 2018 17:14:39 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org On Tue 20 Mar 2018, Martin Gürtler wrote: > ob-plantuml wraps a plantuml source in @startuml/@enduml tags without > checking whether they are already in the source code. This results in > the creation of invalid SVG, at least for newer versions of plantuml, > because the resulting SVG file contains then two XML documents ((I was > using version 1.2018.2, it seems to work though for older plantuml > versions <= 8059). > > So the following does not work > > #+BEGIN_SRC plantuml :file "out.svg" > @startuml > a->b > @enduml > #+END_SRC > > > while this works: > > #+BEGIN_SRC plantuml :file "out.svg" > a->b > #+END_SRC > > Every plantuml example I found contains @startuml/@enduml so all my old > org mode files do contain the tags... I feel the required change is not > very difficult, but unfortunately I do not speak elisp at all... > > Emacs : GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.28) > of 2018-02-19, modified by Debian > Package: Org mode version 9.1.7 (9.1.7-20-ge1f1ac-elpa @ /home/guertler/.emacs.d/elpa/org-20180319/) > > Thanks for considering, > > Martin Note that newer versions of plantuml supports additional diagram types, so diagrams may need to use: @startuml .. @enduml @startsalt .. @endsalt @startdot .. @enddot @startditaa .. @endditaa @startgantt .. @endgantt It is expected that support for new diagram types will use keywords starting with "@start" and "@end" as delimiters. See "Generalisation" at http://plantuml.com/ditaa for more details. AndyM