From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uExQHk8ITmXmAwEAauVa8A:P1 (envelope-from ) for ; Fri, 10 Nov 2023 11:39:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uExQHk8ITmXmAwEAauVa8A (envelope-from ) for ; Fri, 10 Nov 2023 11:39:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 612FC138BE for ; Fri, 10 Nov 2023 11:39:11 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699612751; a=rsa-sha256; cv=none; b=Xon1lLvpI4pqnSHY836fNM4eiDxSGrYSY0glnoYz9ZzUa8RCNNi8KKpXxWc52LCJ1micsh CEY2jgiYqh5f4kFiE2FwQNRVV0AgpM+3CD+zurkVqzzNXgwLS22dErY0Gmspv6l+Q+aCRU U3aPzUjpReM/wILtihBD4MKoNgG1IBf/4s4umxUxjfeHM7DDRl5KxrsAI+vjUEJ5DhzkfM JW9zQcWvGPutPr8aIAQasTpk1WTb/dYcjsjM3KbVX/PH8f3vPcAO2VNVogCJU+gfN7jtm7 jTIbKPJadsWTIEmGr8fU7xA0+OdnPm3WHFUPRO0KsdvyuWb29xGcxXw9kBH4lA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699612751; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=upO9SqBHeYRDil2KpmxJsnuQ93EPioT2ZzJSoi38ZVU=; b=QTVIgjbcICvAwOcZ5hKrpxsHJgZy32AIzQ0sxMBQPC+ZMu1W/an4TsbdlYtLK6vo5o0MZh PpImD+Q6zEl1Y1L2r2+B7l/h3clp3aDhRFQcFa3vT5K45+IKFrNh/GpO95vgwzQAi1K/MA c/wYwAHxWRhR+V0n31GuBYRgeil0DzbuPD0ny2rRo8wCPEgGRf362WnJuiRmZHeygmFNa6 xp4rQomWwvxhRKyK8E9GCtRBmgEXWfNg1ovuSV1qWjBOGdelek7wt53OHGwMhy6PhP2D2w ZEwnxgSfPU03NtSb3X8/QSpUOtOc5c3UFz/YL8CnwWxvNhjk5fPMl2Ds9D+kMQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1OuI-0004xQ-Mg; Fri, 10 Nov 2023 05:38:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1OuF-0004nW-41 for emacs-orgmode@gnu.org; Fri, 10 Nov 2023 05:38:31 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1OuC-0002pg-Vi for emacs-orgmode@gnu.org; Fri, 10 Nov 2023 05:38:30 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1r1Ou9-0001xJ-VV for emacs-orgmode@gnu.org; Fri, 10 Nov 2023 11:38:25 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [TASK] Allow customizeable ditaa executable in ob-ditaa.el Date: Fri, 10 Nov 2023 17:38:19 +0700 Message-ID: References: <87wmvhnr8b.fsf@t14.reltub.ca> <871qdo5sdh.fsf@web.de> <87y1fwtkth.fsf@localhost> <87sf5f7h04.fsf@t14.reltub.ca> <87zfzmnvl7.fsf@t14.reltub.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <87zfzmnvl7.fsf@t14.reltub.ca> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 612FC138BE X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -3.46 X-Spam-Score: -3.46 X-TUID: rKqGEc8hhJ53 On 10/11/2023 10:19, Leo Butler wrote: > On Thu, Nov 09 2023, Max Nikulin wrote: > >> diff --git a/lisp/ob-ditaa.el b/lisp/ob-ditaa.el [...] >> should allow to set :java to >> >> flatpak-spawn --host toolbox run /usr/bin/ditaa >> >> without abusing of org-ditaa-jar-path. Untested. > > Doesn't this abuse the `java' header argument, which is intended to pass > arguments to the java runtime? or `org-babel-ditaa-java-cmd'. My point is that requirement of non-empty `org-ditaa-jar-path' confused Florin to the degree when workarounds looked impossible. Notice that setting org-ditaa-jar-path "/usr/bin/ditaa" still requires spreading of "flatpack-spawn ..." over `org-babel-ditaa-java-cmd', :java, and `org-ditaa-jar-option'. fortunately some of these options may be sent empty and other will not quote spaces, etc. Whole "flatpack-spawn ... ditaa" command can not be put to `org-ditaa-jar-path' > I think that it would be best to implement the change to mirror that > done in ob-plantuml, as Ihor suggested earlier. Agree. I appreciate consistency in treatment of similar cases. I am not sure in the following idea. Perhaps a concept of "launcher" (or "runner") may be introduced. Launchers may be stacked. So for a jar file launcher is "java @:java -jar" that may be combined with "toolbox run" and "flatpak-spawn --host" launchers. > My reading of the documentation and ob-plantuml.el is that it is not > possible to use the `java' header argument in the way you propose for > ob-ditaa.el. Since nobody has proposed a patch for ob-ditaa, I decided that making a workaround easier is an improvement. #+property: header-args:ditaa :java ... would not affect ob-plantuml. P.S. I am unsure what is proper balance between flexibility/convenience and security. A file downloaded from net should not be able to change executables and their options without consent from the user. Unfortunately attempts to suppress at least shell expansion will lead to more verbose configuration.