emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [RFC][PATCH] Allow to export to ascii custom link types as notes
Date: Mon, 23 Oct 2023 18:00:47 +0700	[thread overview]
Message-ID: <uh5jp1$8bm$1@ciao.gmane.io> (raw)
In-Reply-To: <8734y1aeae.fsf@localhost>

On 23/10/2023 16:17, Ihor Radchenko wrote:
> Max Nikulin writes:
> 
> WRT cons vs. plist, I am mostly neutral. Slightly in favour of plist for
> future extensibility.
> 
> I am not sure what you mean by callback.

Originally I had an idea that :export should call some function that 
adds a note to info. Now I have another proposal. Instead of returning a 
cons, :export function should return result of some new function, e.g. 
(org-ascii-make-link-with-note NOTE DESCRIPTION), so a `cons' or a plist 
becomes an implementation detail that may be changed any time. The only 
inconvenience is necessity to declare this function to allow lazy 
loading of ox-ascii and perhaps to avoid circular dependencies.

> May you provide an example when the angle brackets are not added?

angle and square brackets inconsistency

--- 8< ---
# (require 'ol-man)
# (setq org-ascii-links-to-notes nil)

- web :: [[http://orgmode.org][Org mode]]
- man :: [[man:man][man]]
- internal :: [[Heading][heading]]

* Heading
--- >8 ---
--- 8< ---
web
       [Org mode] (<http://orgmode.org>)
man
       man (http://man.he.net/?topic=man&section=all)
internal
       heading (See section 1)


1 Heading
═════════
--- >8 ---

>>>> +           (if (string-match-p "\\`\u200b*\\[.*\\]\u200b*\\'" anchor)
>>>> +               anchor
>>>> +	     (format "[%s]" anchor))
>>>
>>> This is out of scope of the patch, isn't it?
>>
>> Not really.
> 
> Do you mean "this is out of scope"?

I mean, it is a related change. E.g. ox-html and ox-latex do not add 
square brackets around link descriptions, it is specifics of ox-ascii. 
Square brackets are sometimes added for inline links, sometimes they are 
not. Square brackets are always added for links as notes. I would avoid 
duplicated square brackets when links are formatted as notes and for 
inline links when description is formatted with brackets.




  reply	other threads:[~2023-10-23 11:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 17:21 [RFC][PATCH] Allow to export to ascii custom link types as notes Max Nikulin
2023-10-22  9:13 ` Ihor Radchenko
2023-10-22 17:05   ` Max Nikulin
2023-10-23  9:17     ` Ihor Radchenko
2023-10-23 11:00       ` Max Nikulin [this message]
2023-10-23 12:09         ` Ihor Radchenko
2023-10-24  8:11           ` Max Nikulin
2023-10-24 10:40             ` Ihor Radchenko
2023-10-24 15:06               ` [PATCH] ox-ascii.el: Consistently add brackets around links (was: Re: [RFC][PATCH] Allow to export to ascii custom link types as notes) Max Nikulin
2023-10-25 10:34                 ` Ihor Radchenko
2023-10-26 16:46                   ` man pages references (Re: [PATCH] ox-ascii.el: Consistently add brackets around links) Max Nikulin
2023-11-05 12:08                     ` Ihor Radchenko
2023-10-27 14:36               ` [RFC][PATCH] Allow to export to ascii custom link types as notes Max Nikulin
2023-10-25 15:16           ` [RFC][PATCH v2] " Max Nikulin
2023-11-07  9:30             ` Ihor Radchenko
2023-11-07 11:48               ` Max Nikulin
2023-11-07 11:58                 ` Ihor Radchenko
2023-11-08 10:23                   ` Max Nikulin
2023-11-08 10:45                     ` Ihor Radchenko
2023-11-08 10:57                       ` Max Nikulin
2023-11-08 11:16                         ` Ihor Radchenko
2023-11-09 11:12                           ` Max Nikulin
2023-11-11 11:17                             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='uh5jp1$8bm$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).