From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-sqlite: Use a transient in-memory database by default
Date: Sat, 12 Aug 2023 16:38:04 +0700 [thread overview]
Message-ID: <ub7jtu$92t$1@ciao.gmane.io> (raw)
In-Reply-To: <m2jzu9t3xu.fsf@me.com>
On 06/08/2023 07:22, Rudolf Adamkovič wrote:
> * lisp/ob-sqlite.el (org-babel-execute:sqlite): Default ':db' to
> ":memory:" instead of throwing an error.
This commit message entry does not reflect changed approach clearly
enough. Not passing :db is a bit different from default :memory:. Sorry
that I have not noticed it earlier. Since the commit has been pushed, I
do not expect any further action in response.
> @@ -97,7 +96,7 @@ This function is called by `org-babel-execute-src-block'."
> (member :html others) separator)
> ""
> "-csv"))
> - (cons "db " db)))
> + (cons "db" (or db ""))))
My expectation was that sqlite3 should print a warning, but actually it
does not.
echo "select 1" | sqlite3
1
sqlite3
SQLite version 3.31.1 2020-01-27 19:55:54
Enter ".help" for usage hints.
Connected to a transient in-memory database.
Use ".open FILENAME" to reopen on a persistent database.
In this sense I would prefer the previous version of the patch, but I
admit, it is my fault that I did not tried it despite a week passed.
next prev parent reply other threads:[~2023-08-12 9:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 12:59 [PATCH] ob-sqlite: Use a transient in-memory database by default Rudolf Adamkovič
2023-05-03 15:12 ` Max Nikulin
2023-05-03 16:32 ` Max Nikulin
2023-05-04 10:27 ` Ihor Radchenko
2023-05-06 20:40 ` Rudolf Adamkovič
2023-05-07 14:45 ` Max Nikulin
2023-06-13 9:59 ` Ihor Radchenko
2023-06-19 12:42 ` Rudolf Adamkovič
2023-06-20 10:58 ` Ihor Radchenko
2023-08-03 12:35 ` Rudolf Adamkovič
2023-08-04 8:08 ` Ihor Radchenko
2023-08-04 22:57 ` Rudolf Adamkovič
2023-08-05 3:00 ` Max Nikulin
2023-08-06 0:22 ` Rudolf Adamkovič
2023-08-12 8:22 ` Ihor Radchenko
2023-08-12 9:38 ` Max Nikulin [this message]
2023-08-05 3:06 ` [accessibility] worg obscures text (Re: [PATCH] ob-sqlite: Use a transient in-memory database by default) Max Nikulin
2023-08-05 3:20 ` Samuel Wales
2023-08-05 3:22 ` Samuel Wales
2023-08-10 16:13 ` Max Nikulin
2023-08-10 23:35 ` Samuel Wales
2023-08-05 9:14 ` [PATCH] ob-sqlite: Use a transient in-memory database by default Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ub7jtu$92t$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).