From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WOJAFjipM2RKowAASxT56A (envelope-from ) for ; Mon, 10 Apr 2023 08:14:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qG9KFjipM2TkmAAA9RJhRA (envelope-from ) for ; Mon, 10 Apr 2023 08:14:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17CED38943 for ; Mon, 10 Apr 2023 08:14:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plkmJ-0004bg-L4; Mon, 10 Apr 2023 02:13:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plkmH-0004aj-BH for emacs-orgmode@gnu.org; Mon, 10 Apr 2023 02:13:21 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plkmF-0003xf-Le for emacs-orgmode@gnu.org; Mon, 10 Apr 2023 02:13:20 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1plkmE-0005Nd-33 for emacs-orgmode@gnu.org; Mon, 10 Apr 2023 08:13:18 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el Date: Mon, 10 Apr 2023 13:13:11 +0700 Message-ID: References: <874juewk4k.fsf@kyleam.com> <87r0xi5jx7.fsf@gnu.org> <87o7obn0dp.fsf@localhost> <877cuzmreg.fsf@localhost> <87ile5o3vb.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US In-Reply-To: <87ile5o3vb.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.888, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681107256; a=rsa-sha256; cv=none; b=uH5HJ803H6KrYrJnMur7sxBc1A/Z/cTCUGv51h+Z/RgqRkde1VtyYLmjAodKCJstaUpUT7 Y65C9kt7w+MFJqMbntIop7tvvFgd/86y0nWXE4O0Oj42HQaV6lBxTNuGWarZziBu1wM3dp ciWlhzEW8lq5huy4AVXgJrpMfR5x5AmG4FTa0w3kA+3DFf2uHsMX+ED499d87IHF7J3rNK /cCaIXJeev11h/nVB1w3GFsOiLsBiNifDbLdyby9+eWQMGieefxOORrfb0gdnTvCOiyqCW mlwQnJojHexaETtkAG2FAQWaTgZjnmntTl/TTwy51U9d9rVsWZotMJC3aqfMxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681107256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mNVIXUEE0EwjLOePpYaOV3eORIJusVgfb5dS7vEwis0=; b=VmKfUnxxJ1imgdJDVO9iC6irM2uoHO8hAUNNIxfqLXD+8diA37u18E3V6sqBgF+3/bcbgf R0YUxIrwWvRNGfatwr1j743USvWuIm/uVWQYqvPT9oRfQi4LZ904Qy1uWLNdlYvmihkHHy CdKwRoZq/FhKNcJJL6FNYm0XjsLflM3OUxsYrCY+s6lyHKwlSJuhcSnXGvx/xy7e6X39oQ sQ2cq9k4ziM4jF3cFI26XLzlrMQ91QmjtFuSBJevBRcWyZ1xL7fMwirNopP22pjGV+jM0Q Ub8sUrJ+OgMnZwh6K3vc+A9L2nCjfLNE5G/aCVf1zUiahLqMfJuKSt+C1wLzVQ== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.22 X-Spam-Score: -3.22 X-Migadu-Queue-Id: 17CED38943 X-TUID: vAuCGLT9OJ0Z On 09/04/2023 15:29, Ihor Radchenko wrote: > Max Nikulin writes: > >> I would consider adding to ELPA README and Org manual something like: >> >> If compiling of ELPA packages causes a lot of warnings related to >> `org-assert-version' then delete just installed Org package, start new >> Emacs session ensuring that Org is not loaded (-q?) and try to install >> from such clean state. > > What about creating org-assert-version.el file that will contain > something like > > (if (fboundp 'org-assert-version) > (org-assert-version) > (warn "")) > > Then, instead of (org-assert-version) call, we can put > (load "org-assert-version.el") in Org libraries. I believed that the only way to make `org-assert-version' effective is to put org version in every Org compiled .elc file, so you suggestion makes version check useless. An earlier idea was to put `org-assert-version' *definition* to a separate file keeping call in each file as one time workaround to ensure that `org-assert-version' is defined while compiling when an older Org version is loaded to Emacs < 29. Currently I do not understand: - Why presence of .el files in the same directory (old Org version) with .elc files affects result of compilation (at least for Emacs-28)? - Why even when the `org-assert-version' macro is defined, an error is signaled on attempt to load a compiled file with unexpanded (org-assert-version) call (a file compiled with warning "the function ‘org-assert-version’ is not known")? Unfortunately I did not bookmarked discussions containing details related to straight.el issues, so I am unsure if the problems are the same as for installing from ELPA by package.el.