From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IPaON3VDKGSfCwAASxT56A (envelope-from ) for ; Sat, 01 Apr 2023 16:45:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IJ2IN3VDKGRf+wAA9RJhRA (envelope-from ) for ; Sat, 01 Apr 2023 16:45:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A21102D377 for ; Sat, 1 Apr 2023 16:45:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1picSt-00089G-4O; Sat, 01 Apr 2023 10:44:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1picSs-000894-7K for emacs-orgmode@gnu.org; Sat, 01 Apr 2023 10:44:22 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1picSq-0006Zi-QE for emacs-orgmode@gnu.org; Sat, 01 Apr 2023 10:44:22 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1picSo-0001Pp-MT for emacs-orgmode@gnu.org; Sat, 01 Apr 2023 16:44:18 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el Date: Sat, 1 Apr 2023 21:44:10 +0700 Message-ID: References: <874juewk4k.fsf@kyleam.com> <87r0xi5jx7.fsf@gnu.org> <87o7obn0dp.fsf@localhost> <877cuzmreg.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US In-Reply-To: <877cuzmreg.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680360309; a=rsa-sha256; cv=none; b=onwRCAXLUH1sFw9f2Dvpzr9ppmF+17AjxHF//WeMOXoQyPKJcTspdHhWsfUiv2seLag37w 6sr7QGz42xAl5gPq59eDEbHKnrNNe0goczSesEmscym24U5yr0z+htb+SxGo2TO9F9+nlU zyc5/ctkT4QSbRBRLsKq31dF+1MH0PD//iGhHJ9jY45PThZz7cJS7I+v5HGoaXUXCJT/TO 18ZRG45RLL1QgDJPkTCizFpA2y4GYZEprNx//RBH0QakFDHPasltN6V0i7viU1olrXOjPG 3OvVmy1E31SAuBDmLL85TRbt/mfoF4ekolA2UYZSoIN+pYes1GesEp9zDsSwZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680360309; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=y8EbcLqkadzLv+T5fWR+ztuB3h+bHV0x71nl6CObHZk=; b=BMnpDxFoqNTTnmSKycZR0p9QybUv/7lYwmPI305gklbpOrcSnsfDOrbENgDBB2sZoj01CU +Uats1mSxjLF5cS8J7F3PCYdVM5GAQaUtMsaPIrAERx95lcRs0tPoinA1nJjMj8VMNzHwG m5SqRXGQvalzUSEHqpkTQDxdsuxpE5gRq69RPf58gytTcQ1D0NA5+s3V5Y88hYNJtw7Bhp 7DiF8qTH3cNZwMYTWzOL4yHbt2jjqdM5ZiHBSeryM3AgF4Bofp9EJEZjcZW0D9QbVZMofY hV3trTY+VO1TxKpPobIkiUFL4cSxXa5MCmIzQDvJG7T4eXQPlg9Ylo5UOeLUyA== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.43 X-Spam-Score: -2.43 X-Migadu-Queue-Id: A21102D377 X-TUID: tWYTD2OWJ97/ On 29/03/2023 23:52, Ihor Radchenko wrote: > Max Nikulin writes: >> Sorry, I have not tried to compile Emacs myself and I am really puzzled >> why you was not able to reproduce the issue. > > I was able to reproduce on Debian using virtual machine. To be precise, I am surprised that you are unable to reproduce the issue with older Emacs version compiled from source. > https://old.reddit.com/r/orgmode/comments/123qnqq/workaround_for_orgassertversion_problem_not/ I have no clue why your patch should help in this case. My hypothesis: the user has `use-package' org-roam in their init file. Attempt to update org caused compiling new org when old version is already loaded due to Emacs-27 does not contain fixes that reload package that is installed. Next time load of org failed because it is result of mixed version compilation. >> I am in doubts if emacs version should be checked or it should be e.g. >> (fboundp 'org-assert-version). > > It is indeed a cleaner approach. I am not sure. Perhaps it should be (or (fboundp 'org-assert-version) (new-package-management-code)). Since testing for private function is not a reliable solution, only version check is available.