From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WMSMHwEZ4WO3HgEAbAwnHQ (envelope-from ) for ; Mon, 06 Feb 2023 16:13:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UGJlHwEZ4WPlTwEAauVa8A (envelope-from ) for ; Mon, 06 Feb 2023 16:13:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5160F9E0 for ; Mon, 6 Feb 2023 16:13:04 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP3A3-0002qX-2O; Mon, 06 Feb 2023 10:12:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP39z-0002lr-Km for emacs-orgmode@gnu.org; Mon, 06 Feb 2023 10:11:59 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP39x-0001Pl-T1 for emacs-orgmode@gnu.org; Mon, 06 Feb 2023 10:11:59 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pP39v-0009wx-8N for emacs-orgmode@gnu.org; Mon, 06 Feb 2023 16:11:55 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v5] org.el: Warning for unsupported markers in `org-set-emphasis-alist' Date: Mon, 6 Feb 2023 22:11:48 +0700 Message-ID: References: <87o86mw86r.fsf@localhost> <87fsrxkahq.fsf@nicolasgoaziou.fr> <87fsrxa1j5.fsf@localhost> <878rxoa6lk.fsf@localhost> <87pmqtj09r.fsf@localhost> <87mt9743di.fsf@localhost> <871qqhlskf.fsf@localhost> <87r0v8pcdb.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US In-Reply-To: <87r0v8pcdb.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 17 X-Spam_score: 1.7 X-Spam_bar: + X-Spam_report: (1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.148, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675696385; a=rsa-sha256; cv=none; b=J+9DpzPcSECOmxbzMFGI0b2rMZTaYPHy08Lf7LuIwfS72DMxxrfDmnUgokacpDFHwKbUcI kQSAzrawIRL2BDd2tWAlnCPf5VTmbal6qi4veUaiN09C0s3AWytLcYaSlw+J/GHCrS5tQX m5gSxhk/hibx9vspOoLpqC+rTs1JS8IbV1D5RM3Y/8IJ4S5Gt4+i37aKKnMuiPjaqoTJ6b 35Il6gXJbrKlkGRYRAeXg0bbf/DJjVbJhoJizOgtvqfee36q4iTYzlCBLMN2WA+4t74v3s Qqi2pv4kV7OwJ8gIOMZGKm7eWdvIxYChP/eWBAlW0EzZQ6BT+/Jyj6Nym1IK2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675696385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fpVzXcIxUfiSBPVIB04b7OPC9P5nghhHyiVO08IIxJ8=; b=WY0A4IJyydYEE3DRYYbYLBYS+3UEg4PPfiIhrMlPnDmVXklqKe4DeNVdxYl+Ges8mILucm pfZO210ot0onlE0XEVNdNTl6vL02nXDAtig4cGMp0AjbX0Vp+5zTbk5qIsMhHQBtr/sbEf 1FPg8AV/5bpuCB4LOuqut0nYeWvyeLkqudWKDgdplWLmV6aAlpE6yCr44WU8JklAeoVbM7 SlOHz135PdcnYB905nSvo3bdecw7fHAUDLasuVUFEZlLdzSnDJK9m3CJ+0gPvMY9nuIGd+ bdHfzulLLsdvFa50J6GAzUrGcHggqbdzMs2PgBD7MtwT+BhD5YE88ktdnsplQw== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.79 X-Spam-Score: -0.79 X-Migadu-Queue-Id: B5160F9E0 X-TUID: 2xUmXpI0W2Oy On 02/02/2023 17:53, Ihor Radchenko wrote: > I further improved the patch adding variable watcher. This should catch > everything. See the attached. `add-variable-watcher' may be fragile for lists, but it should catch most obvious attempts to modify the list. To my surprise `add-variable-watcher' is used in just a few places in Emacs sources. > From: Max Nikulin Taking into account your modifications, I think you can reset the commit author. > +(defun org-emphasis-alist--check-value (symbol value &optional operation _) > + "Verify the VALUE of `org-emphasis-alist' SYMBOL. > +Issue a warning when the value is not supported. > +Optional argument OPERATION is intended for `add-variable-watcher' > +usage, which see." > + (when (memq operation '(set let)) I am unsure concerning let. Perhaps the user needs something strange if let is used in some code instead of usual setq in init.el, so behavior may be too noisy. > + (option (const :tag "Deprecated ignored constant" verbatim))))) Looking into easy customization UI I have found current tag text rather confusing. What about "Verbatim (deprecated and ignored)"? Thank you for further improvements of the patch. I will not object if you apply the patch as is. Are you still going to fix the manual a bit? Ihor Radchenko to emacs-orgmode… Re: c47b535bb origin/main org-element: Remove dependency on ‘org-emphasis-regexp-components’ Thu, 18 Nov 2021 20:25:33 +0800. https://list.orgmode.org/87tug93b2a.fsf@localhost