From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +PrdBlzHrmMwMQAAbAwnHQ (envelope-from ) for ; Fri, 30 Dec 2022 12:11:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qNsbBlzHrmM8uQAAG6o9tA (envelope-from ) for ; Fri, 30 Dec 2022 12:11:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 821D3332EF for ; Fri, 30 Dec 2022 12:11:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBDHc-0002JX-HX; Fri, 30 Dec 2022 06:10:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBDHb-0002JL-9O for emacs-orgmode@gnu.org; Fri, 30 Dec 2022 06:10:39 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBDHZ-0006mt-9g for emacs-orgmode@gnu.org; Fri, 30 Dec 2022 06:10:38 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pBDHT-0005KS-Ig for emacs-orgmode@gnu.org; Fri, 30 Dec 2022 12:10:31 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable Date: Fri, 30 Dec 2022 18:10:22 +0700 Message-ID: References: <87359ld5ye.fsf@kyleam.com> <874ju0j538.fsf@localhost> <87k02fspxa.fsf@localhost> <87edsii4mo.fsf@gnu.org> <87h6xetbfn.fsf@localhost> <878rips273.fsf@bzg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US In-Reply-To: <878rips273.fsf@bzg.fr> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.149, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672398683; a=rsa-sha256; cv=none; b=fQU+Gz//P3tHTuZWnzXMklX6vQIC18zAgHwd59G5MpSocURpepMOWzzBPg2pyrmzbxYuAO 7xDgBV1t6I9ZwepkYskedUI5t3jdekKgO6Aq53OfIIK8AvChzmFjYxkeQPjt9rOrnKAQg1 ijiA8ao4173H58WZ64A12QII4XL/7B6s8V7954iLmMw74WcFHqK4ZLiKI3dun+Tm2VIQQM 0F3WUYLrO8n5QA+F1dOsCDouoIpbgLGtcIKcyfkusRlRBwKqGYyQY2u13d3NJZSDFQbDGr Wtr+v1e4bQPnyU56Q9CU/AMH33WmuN83+x0BD78DT2wqGIFNro3vj3rUW5f3tQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672398683; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mrGWM0YUzwoQuaDzRp0/TMvE0NgLZjbhD+VuDQNRi5s=; b=H7oUs7zD0aa/7MlqpYSBOMG29k7cljZZHmykmK5UMFMyxJZi2OZqEvrnrH8SZsY0r5R/qI exFiaT5Tn9gzbZveA6hT5Me1jF9fP5rBCrfdBBAuUtCGGFM9FstLkhlb5mduQFI7rBtSxA ALli1zXvyJmgSWBWnl6TxtgJ5JrEadaMipacrZqCXRoSoZD0mLg956qIK3Q+xFWsgaqyvh CV+RCA16ttnIlPhNj4ttw81SBXo7gXRu3bZJOGBip62dCcN5kyCNTim/lVe1jnuMrgzNng uWAJiucm9l2jsJcTX2DWx98KtFS2vLdIfOi6NMUFjRLfEvFa54Tid8jOnbOevA== X-Spam-Score: -1.53 X-Migadu-Queue-Id: 821D3332EF Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.53 X-TUID: d0nyiT2usaJT On 30/12/2022 15:52, Bastien wrote: > But are we sure that users need to confirm header args evaluation > separately from code blocks evaluation? I do not think we need to confirm header arguments *separately*, but they should not be executed before asking users. It is not easy to implement request for header arguments in another way. Commit 10e857d42 2022-10-28 11:09:50 +0800 Ihor Radchenko: org-babel-read: Obey `org-confirm-babel-evaluate' was a reaction to Max Nikulin. [BUG][Security] begin_src :var evaluated before the prompt to confirm execution. Thu, 27 Oct 2022 10:18:05 +0700. https://list.orgmode.org/tjct9e$179u$1@ciao.gmane.io The latter partially was caused by demand to open arbitrary Org files downloaded from net in Emacs. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58774 [WISH]: Let us make EWW browse WWW Org files correctly Accidental unsolicited code execution due to unintentional C-c C-c may be rather dangerous, it does not depend if it is source block body, header arguments, or table formula (the latter may still be activated by just TAB). Org-9.5 behavior is not ideal but at least acceptable for most of trusted (e.g. private) Org files.