From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KC7FDE+pmGPbRgEAbAwnHQ (envelope-from ) for ; Tue, 13 Dec 2022 17:33:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2MnJDE+pmGOOGwEAauVa8A (envelope-from ) for ; Tue, 13 Dec 2022 17:33:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C82AA251A7 for ; Tue, 13 Dec 2022 17:33:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p58CL-0005BM-E8; Tue, 13 Dec 2022 11:32:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58CK-0005Ap-7Z for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 11:32:04 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p58CI-0002It-OM for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 11:32:03 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1p58CE-0000pr-Ib for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 17:31:58 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable Date: Tue, 13 Dec 2022 23:31:50 +0700 Message-ID: References: <87359ld5ye.fsf@kyleam.com> <874ju0j538.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670949198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dZeV3vOh8a4FXkPqsfJagJjOutXct6YYBZVTdya3s2k=; b=d8VTd2inwZyL7ru7/wlFId8sDdB0DC0CXDuK1Z5b5lDezVCR1dosg2OgQlrzT7rNcYTsfH o2YhQFqBAKaRHGwd7PTUJz9IbPRbW9Den0CPy+5CPRrioytZUCxG3GoyAV5i0vLmXY0GVb 4uSLZ2VC9viFOF6RBJ+OGnST2YMkiraXgrWt+XJ+IvOW/qsThPy5ythno4UxAMF4aJsrTN btB+QjK0x1RQ3UAnnT5dm2P/DVQaPmHdkVsqmIN1Pujihp0IjjqVtzNShAfKMFFsYw+9AD P7yuECdOJXCeqLdQVUdo9lSbjLNYlYbRT01w9+x0avA2y2qPtpMeY7pL1NdNyA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670949198; a=rsa-sha256; cv=none; b=VjRa/k8zza4t1ffVbflPMQSMC7s7z3JrgZbLX+wooQB9+FuVL9Utd8w2FHwM6bSXhpYke6 TEYFFVJMmqNT6NVOmXqJv4rDtsa7W6M7DftajtLBj0TmnLm97eeHh8Rn4JrGubjvt0R4+k wgwKKl5yR9StVxpwLThkTOqSNv32bkp4Z4zk4f6naNcbW6JEZzGAUrZEHxqBZ7My5PrEgE OROueDcDJhYhRyLiEFbnzPScC6v/oby+9kqJbembiKQZbkhpAoQax8NVf+ZldEmqxU9oEZ FGpQF6rTkM/v2xOpfDB5gIcq5EFnoT1c1KSn6broKEITHfCWr94ViR+tXVP6VQ== X-Migadu-Spam-Score: -0.67 X-Spam-Score: -0.67 X-Migadu-Queue-Id: C82AA251A7 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) X-TUID: WNEKJBLJpVN7 On 13/12/2022 08:53, Tom Gillespie wrote: > +(defcustom org-confirm-babel-evaluate-cell t > + "Confirm before evaluating a cell. > +This follows the same conventions as `org-confirm-babel-evaluate'." Will it be clear to users what "cell" means in this context? Am I wrong that, roughly speaking, the effective value is (and org-confirm-babel-evaluate-cell org-confirm-babel-evaluate)? Should it be described in the docstring? It seems e.g. :eval query affects the latter, but not the former. If it is so then it is too complicated for me to feel firm ground while reasoning on security. I have not decided if it is feasible to add some property to the INFO argument passed to `org-babel-confirm-evaluate' and to put there condition which variable should determine result.