From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CJ4uEkOlmGMuKwEAbAwnHQ (envelope-from ) for ; Tue, 13 Dec 2022 17:16:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EMw0EkOlmGNZfAEAauVa8A (envelope-from ) for ; Tue, 13 Dec 2022 17:16:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C9689109 for ; Tue, 13 Dec 2022 17:16:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p57w8-0004MQ-Gn; Tue, 13 Dec 2022 11:15:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p57w6-0004Kl-Db for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 11:15:18 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p57w5-0002cW-0D for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 11:15:18 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1p57w3-0009vf-6E for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 17:15:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable Date: Tue, 13 Dec 2022 23:15:06 +0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670948163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ImrA0TarFaWsgKEVOTj02NJn42s3wBRo415vXsCMS/o=; b=eCUyNNbjtdOpEK5t5tZaDjyS4AQxlE5Cq/OQveqBeFTHRg55ZNDXvgEfP96PDn5VrinUT7 Efl93e0qar0yHN2BJq5PG8iKUiydAF91jpn6lG4EuQuzIcdBW9tafhrnfp+Y4E41uyM333 sHBBrOAAFm9fodDve/qT0I7Ra5m51Iygb3rYiQ+r3b0yo0tSW1kE89mHTaXCOvYBCAsmdb xhD3H4+fbRutzyEfb0RX28f4i7j7Ovo8sJ7r8q5/IGp3gmPcxnhvHQ7/rVHm8+haP/rD2I SM3XN/2DjzY/k9AQZq7P6pE6HpXeR0Kx5xtUw10VdWw4dhBwRFAO9AVP0Yy7FA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670948163; a=rsa-sha256; cv=none; b=IWfiez3Rdo1xiMZbpiEWeEMhZVCpZXPXSafIVx9H19NExDnZMipoSeJzsWKu+T1ADVrwLp Y7KmNDlYddOkjSmXPyfTpB0MgctdNZnwfNXKwZqoq+GkiDFVQq96MyZ40TR8KPuPpNkR9H HHX0zkTfbxSby5Bl/16H+jn/OyYr2PW07hq6Z0PjRwSlW+G58d3nD55JpVVaOTLS9lo2/O 8nAxIHKbW57u+sgiRvJdUW2SD4aimtNbv4YZIdfMtUIy9lMoJDacRR2QkmRMTOAgjlVpfn U4j/TcRD2ZUkSem5LUzgL+kZhrLqFtEwFsfKJGtY15dFnzka7ccmTORNyVJpIA== X-Migadu-Spam-Score: -0.67 X-Spam-Score: -0.67 X-Migadu-Queue-Id: 0C9689109 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) X-TUID: k+z4Vc8IOvGf On 12/12/2022 03:27, Tom Gillespie wrote: > > #+begin_src elisp :results none > (setq-local > org-confirm-babel-evaluate-cell > (lambda (lang body) > (ignore lang) > (let ((rb (read body))) > (not ; aka (unless condition t) > (or > (member rb > '((or) > (and) > ;; add more forms that are known safe here > )) Thank you, Tom. At first I thought you managed to define a function that treats particular directories as safe (to discriminate own files and files having non-trusted origins). However in such case you would not need additional user option and `org-confirm-babel-evaluate' would be enough. Walking through the passed expression to prove that it has no side effects is an interesting and challenging problem. And frankly speaking, I was confused and believed that it is responsibility of the new function to issue e.g. `yes-or-no-p' prompt. Now I see that it is `org-babel-confirm-evaluate' that shows such prompt.