From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KMHAKPdSYWPfowAAbAwnHQ (envelope-from ) for ; Tue, 01 Nov 2022 18:10:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EA6mJ/dSYWPGZwAAG6o9tA (envelope-from ) for ; Tue, 01 Nov 2022 18:10:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7603814113 for ; Tue, 1 Nov 2022 18:10:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opttd-0003Vp-4u; Tue, 01 Nov 2022 12:13:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opttc-0003Va-Hy for emacs-orgmode@gnu.org; Tue, 01 Nov 2022 12:13:48 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opttS-0001lr-MT for emacs-orgmode@gnu.org; Tue, 01 Nov 2022 12:13:48 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1opttP-0004RE-J3 for emacs-orgmode@gnu.org; Tue, 01 Nov 2022 17:13:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree' Date: Tue, 1 Nov 2022 23:13:29 +0700 Message-ID: References: <87illiyym0.fsf@localhost> <87illhxhc5.fsf@localhost> <87pme7ih1w.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US In-Reply-To: <87pme7ih1w.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667322615; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tUjipdyTuxEmICZtaieMAPe1p/VsTiZuxI+jObtcS9g=; b=n8m57NHGdwj/3FWl7GoP8VaX4JU3fZbiNw3rvoH7Ch/Xlp/p1AvV/Fa/4XriSywjlq9fHo zA3IYHElC3USmOCPYD5ijyDLabgQPjrOyiiwY+BtmsuxErCqPtRgMjnWarkyYYBFlEYvaB N3IFnk/09YtgIkRvGTQdzsrqabqMD+/Hc7awYH1u3ReWz0lE5cblG0HQJkiVOXExEttjY9 UgEmnRca+3psaA865sg1hfwEU7btiExno4WCyeuK3+6CUZtWGfzwTEki4LPTklXDRVupLt TF7a2loLrtuo+dnlUyKVmxNcmfAJTvnEuxm3a8edg2q83qBKt8eQNO2yNTlXdg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667322615; a=rsa-sha256; cv=none; b=uXUgG85WnYK6qwnnB83b3B1ZGmJ/0tsVK4uuP8DZcvjAiNt8+Ee1H+Tc+nF+nEWuAFhTjx 9tfYgnT5Ya7ositRdbfql6S1EPK6PEaUPGCOgMiRfA0jLirXG2rUw8tSr8IN2N6LF/Vo61 WZZYm/MNaWXQPtgM06pMlyjz8+x/RQyuZkYwtdAfFBbJU4no7gpVJ3OHLVEaXdWdcir8u8 8fLMe/vThPvdbUOgQ09LREHSMaHgPAMtIqxoaAWpsTqeH5BFRcWSFmyUMwO3ccAJA2oXiA NZSqrJ5HU68QvdbjMhx0JeXX3e1HbPhoR5icbzCrY/BJd8O/UyyWmA0GYzoTfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.72 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7603814113 X-Spam-Score: 2.72 X-Migadu-Scanner: scn1.migadu.com X-TUID: uPMjuuOpGOOE On 01/11/2022 08:45, Ihor Radchenko wrote: > Since I have no objections to the original patch, applied now. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=57abbd4b928752f2770898b09bbac8126b9d0eb3 > > I also reviewed the usage of (current-kill 0) in the code and applied > two additional improvements: > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=33cbb11d5a522c82dfd9730a0e028a9c3df11518 > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5dc8ea0abee10a787160456f74672da6ff3c3b40 I hope, it does not break anything. I tried to trace possible call paths, but I have not managed to figure out was the original problem caused adding "(and kill-ring" to "(current-kill 0)".