From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: [BUG][Security] begin_src :var evaluated before the prompt to confirm execution
Date: Sat, 29 Oct 2022 00:12:15 +0700 [thread overview]
Message-ID: <tjh2hg$pae$1@ciao.gmane.io> (raw)
In-Reply-To: <87ilk4myev.fsf@localhost>
On 28/10/2022 10:15, Ihor Radchenko wrote:
>
> See the attached tentative patch.
> I tried to balance between annoying users with query and not evaluating
> unsafe code: '-quoted lists and symbols are still evaluated without
> prompt.
>
> Let me know if you see any potential issues.
If I got it right, it prompt user for every variable. I believed that
single prompt is enough for both header arguments and body evaluation.
Maybe I missed some issue with dependent code blocks. If I remember
correctly, each block causes a prompt and I am not going to dispute such
behavior. Unsure if early prompt may increase user confusion since some
blocks will be evaluated not immediately after related prompt but
perhaps after some delay to confirm dependent code.
> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
> index 518831ec6..e10ab401c 100644
> --- a/lisp/ob-core.el
> +++ b/lisp/ob-core.el
> @@ -3165,7 +3165,16 @@ (defun org-babel-read (cell &optional inhibit-lisp-eval)
> ((and (not inhibit-lisp-eval)
> (or (memq (string-to-char cell) '(?\( ?' ?` ?\[))
> (string= cell "*this*")))
> - (eval (read cell) t))
> + ;; Prevent arbitrary function calls.
> + (if (and (memq (string-to-char cell) '(?\( ?`))
> + (not (org-babel-confirm-evaluate
> + ;; See `org-babel-get-src-block-info'.
> + (list "emacs-lisp" (format "%S" cell)
> + '((:eval . yes)) nil (format "%S" cell)
> + nil nil))))
> + ;; Not allowed.
> + (user-error "Evaluation of elisp code %S aborted." cell)
> + (eval (read cell) t)))
> ((save-match-data
> (and (string-match "^[[:space:]]*\"\\(.*\\)\"[[:space:]]*$" cell)
> (not (string-match "[^\\]\"" (match-string 1 cell)))))
next prev parent reply other threads:[~2022-10-28 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 3:18 [BUG][Security] begin_src :var evaluated before the prompt to confirm execution Max Nikulin
2022-10-27 4:22 ` Jean Louis
2022-10-27 4:46 ` Max Nikulin
2022-10-28 4:33 ` Ihor Radchenko
2022-10-28 3:19 ` Ihor Radchenko
2022-10-28 4:11 ` Max Nikulin
2022-10-28 7:30 ` Jean Louis
2022-10-28 3:15 ` [PATCH] " Ihor Radchenko
2022-10-28 17:12 ` Max Nikulin [this message]
2022-10-29 3:19 ` Ihor Radchenko
2022-11-10 5:55 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='tjh2hg$pae$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).