From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree'
Date: Wed, 21 Sep 2022 00:11:41 +0700 [thread overview]
Message-ID: <tgcs8e$vqg$1@ciao.gmane.io> (raw)
In-Reply-To: <87illiyym0.fsf@localhost>
On 20/09/2022 20:16, Ihor Radchenko wrote:
> Max Nikulin writes:
>
>> When REMOVE is non-nil, remove the subtree from the clipboard."
>> (interactive "P")
>> - (setq tree (or tree (and kill-ring (current-kill 0))))
>> + (setq tree (or tree (current-kill 0)))
>> (unless (org-kill-is-subtree-p tree)
>
> The main problem the old code solves is working around user error when
> kill-ring is empty. We do not really want to err in such cases; just
> handle empty kill ring specially.
From my point of view "kill ring is empty" user error clearly describes
what happens in such case, so I do not see any point to spit suggestion
to try simple yank instead.
> I agree that (and kill-ring ...) condition misses the system clipboard.
> The proper way to handle this issue is explicitly catching "Kill ring is
> empty" error thrown by `current-kill' (i.e. `condition-case').
Why do you believe that just allowing to propagate this error is worse?
> We have 3 occurrences of (and kill-ring (current-kill 0)) constructs in
> the code and may fix the problem either by replacing each instance with
> `condition-case' or we may create a separate macro/function in org-macs
> and use it.
Other cases (such as the one at the end of `org-paste-subtree' to
determine if yanked text should be folded) require more care.
next prev parent reply other threads:[~2022-09-20 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 12:02 [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree' Max Nikulin
2022-09-17 11:07 ` Max Nikulin
2022-09-20 13:16 ` Ihor Radchenko
2022-09-20 17:11 ` Max Nikulin [this message]
2022-09-21 8:27 ` Ihor Radchenko
2022-11-01 1:45 ` Ihor Radchenko
2022-11-01 16:13 ` Max Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='tgcs8e$vqg$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).