From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EFnGKsWqJWMlQgEAbAwnHQ (envelope-from ) for ; Sat, 17 Sep 2022 13:08:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6IjNKsWqJWMbBQAA9RJhRA (envelope-from ) for ; Sat, 17 Sep 2022 13:08:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A4B114203 for ; Sat, 17 Sep 2022 13:08:53 +0200 (CEST) Received: from localhost ([::1]:45236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZVgq-0007cE-5G for larch@yhetil.org; Sat, 17 Sep 2022 07:08:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVgB-0007c6-B3 for emacs-orgmode@gnu.org; Sat, 17 Sep 2022 07:08:11 -0400 Received: from ciao.gmane.io ([116.202.254.214]:59800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVg7-0003fG-5f for emacs-orgmode@gnu.org; Sat, 17 Sep 2022 07:08:11 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oZVg1-0006oU-Vu for emacs-orgmode@gnu.org; Sat, 17 Sep 2022 13:08:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree' Date: Sat, 17 Sep 2022 18:07:54 +0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.529, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663412933; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rsnQ5qNENFs2ZyoSTwNAd426OMJJSC5o1Yn7R1AUQqw=; b=mn7Edi2WRT2s6gCCh6N1M/HBd2gr0AAhNgnl8vTF+kkiEvC8DpwQWWdh4mFgTxeiCs3j1r /fMXh2L6CHa7YtLcKtJGWNg/jcBblbnB6R1XTMU+lA6J7AE1CrXfY92jC6Vz46uG1R3ILe 9u52z3teTf38B+vTrDyeKWpQiJl0LXqOGjo4/uaVbsphp/A6bu9IdG2JOHm2ICitBgZNVU fwmtbhQWy6vnby7+A5r+iXTSPq34YYJPSXTPh6ZOck5enic8JT0fmxuiTlrqibKYrAMhN7 OetpTNe79Km55OOSNOOWUUnKK0T5klAqKjNbJwHduZT0C7YoTVCC+dsQiF25Pg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663412933; a=rsa-sha256; cv=none; b=YuRE0+Ab19jy8dYvOX56fvgCC6UH9bjxpFXvMsjL8kQA6I8mjjVqPPeHOcTn0S6x4JQujz QTpGaBedbzs25GYdVZGT/t7/dKlrXjr4cAxeAXx7cHHQ8QSpp8YIA4C3PCrdH3QgCmj9nC QCQcKDguKnd6S3uun48oBMR5yjH2RxOMUNjSaZdh6kooYFAAcvJDA0q05oFFcUofCE1BjV Fx6NFh415lZbE+SvgSxS5T7ukBJPcjs2tWSUz0K2RnCFL+haMSzps19Aee5/EgbQIXCXQE gKL+9Xf+MshjZUI5JKpyTjEaB3BhyxaSTKXSYA+u7hRzGE1mvM5v8hbHGc2dvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6A4B114203 X-Spam-Score: 2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: qRnEu0Zrst2d On 29/11/2021 19:02, Max Nikulin wrote: > =C-c C-x C-y= ~org-paste-subtree~ fails just after Emacs start. > Maybe there are more similar issues. > > - Start *new* instance of emacs. > >     printf '%b' '* Heading\n\nbody\n' | >       xclip -in -selection clipborad >/dev/null > - Try =C-c C-x C-y= or [[elisp:(org-paste-subtree)]] > >   + Actual result is the following message: >     : user-error: The kill is not a (set of) tree(s).  Use ‘C-y’ to > yank anyway This is a reminder about the pending patch. The bug is still present in the main branch. > diff --git a/lisp/org.el b/lisp/org.el > index 025513e7a..55953e97b 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -7774,7 +7774,7 @@ the inserted text when done. > > When REMOVE is non-nil, remove the subtree from the clipboard." > (interactive "P") > - (setq tree (or tree (and kill-ring (current-kill 0)))) "and kill-ring" was added in the commit 63f95c5c4 Carsten Dominik, "Release 4.34" 2008-01-31 11:31:55 +0100 and might be related to Philip Rooke. remember problem in 4.33? Wed, 24 May 2006 08:49:28 +0000 https://list.orgmode.org/loom.20060524T103500-160@post.gmane.org/T/#u but I may trigger let*: Wrong type argument: char-or-string-p, nil on the main branch using `org-capture' with the "* A\nkill: %c" template and empty kill ring and X primary selection and clipboard. Either I can not figure out what was the actual problem or protection was added in unrelated code. So I still believe that my patch fixes the issue, but there may be more bugs around.