emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree'
Date: Sat, 17 Sep 2022 18:07:54 +0700	[thread overview]
Message-ID: <tg49qb$ovb$1@ciao.gmane.io> (raw)
In-Reply-To: <so2fh1$10kj$1@ciao.gmane.io>

On 29/11/2021 19:02, Max Nikulin wrote:
> =C-c C-x C-y= ~org-paste-subtree~ fails just after Emacs start.
> Maybe there are more similar issues.
> 
> - Start *new* instance of emacs.
> 
>      printf '%b' '* Heading\n\nbody\n' |
>        xclip -in -selection clipborad >/dev/null
> - Try =C-c C-x C-y= or [[elisp:(org-paste-subtree)]]
> 
>    + Actual result is the following message:
>      : user-error: The kill is not a (set of) tree(s).  Use ‘C-y’ to 
> yank anyway

This is a reminder about the pending patch. The bug is still present in 
the main branch.

> diff --git a/lisp/org.el b/lisp/org.el
> index 025513e7a..55953e97b 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -7774,7 +7774,7 @@ the inserted text when done.
>  
>  When REMOVE is non-nil, remove the subtree from the clipboard."
>    (interactive "P")
> -  (setq tree (or tree (and kill-ring (current-kill 0))))

"and kill-ring" was added in the commit

63f95c5c4 Carsten Dominik, "Release 4.34" 2008-01-31 11:31:55 +0100

and might be related to

Philip Rooke. remember problem in 4.33? Wed, 24 May 2006 08:49:28 +0000
https://list.orgmode.org/loom.20060524T103500-160@post.gmane.org/T/#u

but I may trigger

   let*: Wrong type argument: char-or-string-p, nil

on the main branch using `org-capture' with the "* A\nkill: %c" template 
and empty kill ring and X primary selection and clipboard.  Either I can 
not figure out what was the actual problem or protection was added in 
unrelated code.

So I still believe that my patch fixes the issue, but there may be more 
bugs around.

next prev parent reply	other threads:[~2022-09-17 11:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 12:02 [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree' Max Nikulin
2022-09-17 11:07 ` Max Nikulin [this message]
2022-09-20 13:16 ` Ihor Radchenko
2022-09-20 17:11   ` Max Nikulin
2022-09-21  8:27     ` Ihor Radchenko
2022-11-01  1:45       ` Ihor Radchenko
2022-11-01 16:13         ` Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='tg49qb$ovb$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).