From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KAW7NX9aH2NeMwAAbAwnHQ (envelope-from ) for ; Mon, 12 Sep 2022 18:12:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GByHNX9aH2P7AQEAauVa8A (envelope-from ) for ; Mon, 12 Sep 2022 18:12:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 572B0B6E0 for ; Mon, 12 Sep 2022 18:12:47 +0200 (CEST) Received: from localhost ([::1]:41588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXm3C-0000OP-EU for larch@yhetil.org; Mon, 12 Sep 2022 12:12:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXlwT-0003K1-LX for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 12:05:49 -0400 Received: from ciao.gmane.io ([116.202.254.214]:32870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXlwR-00013B-R2 for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 12:05:49 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oXlwN-0007JY-Sm for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 18:05:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description Date: Mon, 12 Sep 2022 23:05:35 +0700 Message-ID: References: <87a68c4pyc.fsf@localhost> <8735e091pn.fsf@localhost> <87v8psvorm.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <87v8psvorm.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.153, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662999167; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AHxWR4lFhwOW0Gd8dlLxMWGSFvyk5QP9WgkOehc/fQA=; b=RBN6dPE93Deg9Q28EZzNCCwI0WqntPiyrQa0vGW4HzmmdDaF9HmKo1+zWVWQ8ZSffh1Bao a+a20tHLNel9e+AialsBeNSmWIV6a3S1trLNO+oBwos79hXYcCYmCr1qdMgvV1IAm2zvNT LSUbxCPOye4fzMOhrGUvkR9WI7DaSsCPMDvebcy4XRihhnQGgPwjCIFE3MnmIlBGXvHs86 VSImuMDXrFstYc/Nxq4GC30Kfgg8FE2JdPd6qqXGw85wu19uBTJFsa8TYATLyt++PizWmi KxbwQRegpE/T+mVTqFM3TsqdM1m3qgiMGdUvUJ1fhgtJjF3IlVMdvphFXlX9+A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662999167; a=rsa-sha256; cv=none; b=hhcmMnapiXgCfoC553oPjZKza3k/3ygH9AQ93wvvET34Tpllfzlb7jrfLRmXTs0tgI2GTN uyZyj+D8U/jNZ50ogTOZoINU+/YPunHa19rktpg6ezXS6iT8tTDC//nJEPQ8ZkPYFI2htW WvR8XARqDePh+SHgF571tqCsMRRCUjmkYAHCuLrAfHDkB7MUz7YDgFjxLsghhZ2dE+LU2g iZQmupJjQK57kqY88qVPX0lU7WuH6cOCJzp7yqOyiI2lQOWXjK2htlEXX8hWdbMUHhuaLb ZhS8pvl5WqfT054wIw/Hna3joYdBHuPgRB//8zvFpx9hA01I3K6Xs+7grgvapA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.89 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 572B0B6E0 X-Spam-Score: 2.89 X-Migadu-Scanner: scn1.migadu.com X-TUID: qzq/rUuwY3dA On 12/09/2022 18:02, Ihor Radchenko wrote: > Max Nikulin writes: > >> Unfortunately, your patch does not fix the real issue. The title (not >> nil) should be saved for link description when the heading contains the >> CUSTOM_ID property. I tried to address it in the following patches: >> >> Max Nikulin. Re: Bug: org-store-link uses CUSTOM_ID instead of target >> point. Sat, 6 Nov 2021 19:51:29 +0700. >> https://list.orgmode.org/e2c807a7-1924-6f08-9e63-4f70aee9d3b5@gmail.com > > Does it mean that my patch + the patch you linked can be used to fix the > issue reported in this thread? To fix the #custom_id issue it is enough to commit 2 patches from the linked thread: reverting the change caused duplication of stored #custom_id links and an alternative fix to store link to <>. As to <> links, I am unsure what description should be stored for <>. I do not think it should be heading title and I do not like /full/path/file.org::target that looks strange when file is stripped for a link to the same file, but description contains full path. I proposed (3rd patch) to store just "target" as description, you may prefer nil. Both approaches allows to bypass broken auto-desc logic (which I would like to remove) and to show the prompt for description. I consider your patch as a general improvement because it allows to avoid description = link in more cases.