From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gITmMuS+FGOQlAAAbAwnHQ (envelope-from ) for ; Sun, 04 Sep 2022 17:06:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8H7WMuS+FGOK3AAA9RJhRA (envelope-from ) for ; Sun, 04 Sep 2022 17:06:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C59C3F65B for ; Sun, 4 Sep 2022 17:06:12 +0200 (CEST) Received: from localhost ([::1]:56278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUrCN-00086j-3F for larch@yhetil.org; Sun, 04 Sep 2022 11:06:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUrBj-00085V-6Z for emacs-orgmode@gnu.org; Sun, 04 Sep 2022 11:05:33 -0400 Received: from ciao.gmane.io ([116.202.254.214]:58770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUrBh-0001jV-1f for emacs-orgmode@gnu.org; Sun, 04 Sep 2022 11:05:30 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oUrBd-00098O-80 for emacs-orgmode@gnu.org; Sun, 04 Sep 2022 17:05:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ol-info: Enable :insert-description feature Date: Sun, 4 Sep 2022 22:05:17 +0700 Message-ID: References: <87zgl1npow.fsf@localhost> <87v8s8n1bm.fsf@heagren.com> <87let39d3c.fsf@localhost> <877d4flu3x.fsf@heagren.com> <87cze5e84m.fsf@localhost> <87tu7gkb4l.fsf@heagren.com> <87y1ws6o0c.fsf@localhost> <87k08bjw0t.fsf@heagren.com> <47248a4f-10aa-0980-c054-563f30c05aaa@gmail.com> <87mtd0gthe.fsf@heagren.com> <78b97c9e-fced-0ee4-f3f2-3cbe81080ffa@gmail.com> <87sfms9dx7.fsf@localhost> <87v8rmd53g.fsf@localhost> <871qu9xv8q.fsf@heagren.com> <0da49392-26c6-8ba3-f657-647522d59342@gmail.com> <87zggrg2om.fsf@heagren.com> <87edy3t8o0.fsf@localhost> <87tu6zf2o1.fsf@heagren.com> <871qu3rpt9.fsf@localhost> <8bbccdb4-52f4-b9b5-eb10-252bb15108ec@gmail.com> <87a68hn9es.fsf@localhost> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------TjgxGCS6v4Xihqn3FJDDUvCs" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <87a68hn9es.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 18 X-Spam_score: 1.8 X-Spam_bar: + X-Spam_report: (1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.978, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662303972; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=otDeTQXoy/bj7UgNBn93Tu+8QEyzJaWEnGT+E1VUd7g=; b=N4Xd1bdzFmnOfM2JE4+7qzcejSSy0OmOB2oB8jJxY1vgZufHAoDjqDP9GJ7q4LvSAsl5QU EVE3oT9NDUZmEptLa1xj/MlxaSfHdAABN/VQHH+l1bzsseAfmvyiMCJoabX2PwQt9RvAD5 Hg8r5LbyYI1u9/5izGTdey/o19q7vQhsSJAZbFufqY3pHZmv5TIPyvRn7vNirGiB84wja8 KPoMRuUPGxD9sNNdlMstfUlqGQr3VrlfQzkoNqfv+0nZegG6UGK9oB/e/+Wfur3BU3EPOA in/YoH0SuKDZ+rW13sAKoET0Avz5x7Sf90CfSF7l+XmLe7+KUaZhMFW3wDyCIA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662303972; a=rsa-sha256; cv=none; b=PX0rXz1isQr1+ZNANB0Lb8fIJF9rjsZwsZ5w4bwPyvObtp13TFIQnVbfha6J92DxTOxSpq TuEIEyBvIjLgxPkYuN3hiMchtAJIPb9jal4i4o8DK7XnvyIpZWYFdRAG0OsLHqJ6vRdfP/ yJS4g2aC/dJWNXZcaa/loKeSJXCbu/Rn/cAleCDMePaRguFn3i8nmCTKelhQFd4aGHfBef Bd+N9/0AnEILHdP3MaVhixPC4Mvl1KMK6CfLvKVLr9rG6emWqfkqpodrHUTO19TcWJAAC8 4orRT7NU5I/7u77KlN7PB/RW0K0e7yZb6xf/VxLJscE7/1ObLT3933ftKp9Ckw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3C59C3F65B X-Spam-Score: 4.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: LGAoVxD64tNd This is a multi-part message in MIME format. --------------TjgxGCS6v4Xihqn3FJDDUvCs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/08/2022 14:00, Ihor Radchenko wrote: > Max Nikulin writes: > >> To get impression of the new feature in action, I modified ol-info.el. >> First patch does not depend on :insert-description and might be useful >> per se. Second one just enables the feature. > > Thanks! The patches look useful. > You should also add an entry to ORG-NEWS. Otherwise, I just have two > minor comments. I have realized that I did not address this comment. See the first attachment. I have noticed `org-trim' function, so second attached patch replaces `string-trim' in the newly added code to this function native to Org. Unfortunately `org-unbracket-string' can not handle empty suffix, but the fix is rather simple, so `string-remove-prefix' becomes unnecessary as well. The only reason of this patch is that earlier subr-x was avoided, see e.g. https://list.orgmode.org/87sg0onfrw.fsf@nicolasgoaziou.fr/ Patches are independent and neither of them is strictly necessary, I do not mind if they would be ignored. --------------TjgxGCS6v4Xihqn3FJDDUvCs Content-Type: text/x-patch; charset=UTF-8; name="0001-ORG-NEWS-org-info-description-as-command.patch" Content-Disposition: attachment; filename="0001-ORG-NEWS-org-info-description-as-command.patch" Content-Transfer-Encoding: base64 RnJvbSA3ZmZmYWNkZGE2MDE1Y2VlODk1ZThlZGRiNTU0YmNlMWI4MmRhNmQyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXggTmlrdWxpbiA8bWFuaWt1bGluQGdtYWlsLmNv bT4KRGF0ZTogV2VkLCAzMSBBdWcgMjAyMiAwOToxNToxNyArMDcwMApTdWJqZWN0OiBbUEFU Q0ggMS8yXSBPUkctTkVXUzogYG9yZy1pbmZvLWRlc2NyaXB0aW9uLWFzLWNvbW1hbmQnCgoq IGV0Yy9PUkctTkVXUzogTWVudGlvbiB0aGF0IGBvcmctaW5mbycgdXNlcyBgOmluc2VydC1k ZXNjcmlwdGlvbicsCmEgbmV3IGZlYXR1cmUgb2YgYG9yZy1saW5rLXBhcmFtZXRlcnMnLgot LS0KIGV0Yy9PUkctTkVXUyB8IDExICsrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTEg aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2V0Yy9PUkctTkVXUyBiL2V0Yy9PUkctTkVX UwppbmRleCBkNmQ5OWE2NGIuLjcxM2E4NTBmNiAxMDA2NDQKLS0tIGEvZXRjL09SRy1ORVdT CisrKyBiL2V0Yy9PUkctTkVXUwpAQCAtNDU1LDYgKzQ1NSwxNyBAQCBwcm9tcHRpbmcgZm9y IGEgbGluayBkZXNjcmlwdGlvbi4gIEl0IGNhbiBiZSBhIHN0cmluZyAodXNlZCBhcy1pcykg b3IKIGEgZnVuY3Rpb24gKGNhbGxlZCB3aXRoIHRoZSBzYW1lIGFyZ3VtZW50cyBhcwogfm9y Zy1tYWtlLWxpbmstZGVzY3JpcHRpb24tZnVuY3Rpb25+IHRvIHJldHVybiBhIHN0cmluZyB0 byB1c2UpLgogCitBbiBleGFtcGxlIG9mIGEgc3VjaCBmdW5jdGlvbiBmb3IgPWluZm86PSBs aW5rcyBpcworfm9yZy1pbmZvLWRlc2NyaXB0aW9uLWFzLWNvbW1hbmR+LiAgVG8gYWNjZXNz IGEgbWFudWFsIHNlY3Rpb24gb3V0c2lkZQorb2YgT3JnLCBkZXNjcmlwdGlvbiBtYXkgYmUg cGFzdGVkIHRvIHNoZWxsIHByb21wdCBvciBldmFsdWF0ZWQgd2l0aGluZworRW1hY3MgdXNp bmcgPU0tOj0gKHdyYXBwZWQgaW50byBwYXJlbnRoZXNpcykuICBGb3IgZXhhbXBsZSwKK2Rl c2NyaXB0aW9uIG9mIHRoZSA9aW5mbzpvcmcjVGFncz0gbGluayBpcyA9aW5mbyAiKG9yZykg VGFncyI9LiAgVG8KK3Jlc3RvcmUgZWFybGllciBiZWhhdmlvciBhZGQgdG8geW91ciBFbWFj cyBpbml0IGZpbGUgdGhlIGZvbGxvd2luZzoKKyMrYmVnaW5fc3JjIGVsaXNwIDpyZXN1bHRz IHNpbGVudCA6ZXZhbCBuZXZlci1leHBvcnQKKyAgKHdpdGgtZXZhbC1hZnRlci1sb2FkICdv bC1pbmZvCisgICAgKG9yZy1saW5rLXNldC1wYXJhbWV0ZXJzICJpbmZvIiA6aW5zZXJ0LWRl c2NyaXB0aW9uIG5pbCkpCisjK2VuZF9zcmMKKwogKioqIE5ldyBsaXN0IG9mIGxhbmd1YWdl cyBmb3IgTGFUZVggZXhwb3J0OiB+b3JnLWxhdGV4LWxhbmd1YWdlLWFsaXN0fiAKIAogfm9y Zy1sYXRleC1sYW5ndWFnZS1hbGlzdH4gdW5pZmllcyBpbnRvIGEgc2luZ2xlIGxpc3QgdGhl IG9sZCBsYW5ndWFnZQotLSAKMi4yNS4xCgo= --------------TjgxGCS6v4Xihqn3FJDDUvCs Content-Type: text/x-patch; charset=UTF-8; name="0002-ol-info-Use-org-function-instead-of-subr-x.patch" Content-Disposition: attachment; filename="0002-ol-info-Use-org-function-instead-of-subr-x.patch" Content-Transfer-Encoding: base64 RnJvbSBlZjI5ZTE0MzU0NWI0YzE4MDZhYmZiOGNhMDcyZjdjOTg4NDJmZmYyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXggTmlrdWxpbiA8bWFuaWt1bGluQGdtYWlsLmNv bT4KRGF0ZTogV2VkLCAzMSBBdWcgMjAyMiAwOToyMTo0NyArMDcwMApTdWJqZWN0OiBbUEFU Q0ggMi8yXSBvbC1pbmZvOiBVc2Ugb3JnIGZ1bmN0aW9uIGluc3RlYWQgb2Ygc3Vici14Cgoq IGxpc3Avb3JnLW1hY3MuZWwgKG9yZy11bmJyYWNrZXQtc3RyaW5nKTogSGFuZGxlIGVtcHR5 IHN1ZmZpeCBzdHJpbmcuCiogbGlzcC9vbC1pbmZvLmVsIChvcmctaW5mby0tbGluay1maWxl LW5vZGUpOgoob3JnLWluZm8tZGVzY3JpcHRpb24tYXMtY29tbWFuZCk6IFVzZSBgb3JnLXRy aW0nIGFuZApgb3JnLXVuYnJhY2tldC1zdHJpbmcnIGluc3RlYWQgb2YgYHN0cmluZy10cmlt JyBhbmQKYHN0cmluZy1yZW1vdmUtcHJlZml4JyBmcm9tIHRoZSBzdWJyLXggcGFja2FnZS4K LS0tCiBsaXNwL29sLWluZm8uZWwgIHwgOSArKysrLS0tLS0KIGxpc3Avb3JnLW1hY3MuZWwg fCAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vbC1pbmZvLmVsIGIvbGlzcC9vbC1pbmZvLmVsCmlu ZGV4IGU1NGZlZGMwNi4uZDMzMmIyODM3IDEwMDY0NAotLS0gYS9saXNwL29sLWluZm8uZWwK KysrIGIvbGlzcC9vbC1pbmZvLmVsCkBAIC0zMCw3ICszMCw2IEBACiAKIDs7OyBDb2RlOgog Ci0ocmVxdWlyZSAnc3Vici14KSA7IGBzdHJpbmctdHJpbScsIGBzdHJpbmctcmVtb3ZlLXBy ZWZpeCcKIChyZXF1aXJlICdvcmctbWFjcykKIChvcmctYXNzZXJ0LXZlcnNpb24pCiAKQEAg LTc4LDExICs3NywxMSBAQCBGaWxlIG1heSBiZSBhIHZpcnR1YWwgb25lLCBzZWUgYEluZm8t dmlydHVhbC1maWxlcycuIgogICAgICAgJygiZGlyIiAuICJUb3AiKQogICAgIChzdHJpbmct bWF0Y2ggIlxcYFxcKFteIzpdKlxcKVxcKD86WyM6XTo/XFwoLipcXClcXCk/XFwnIiBwYXRo KQogICAgIChsZXQqICgobm9kZSAobWF0Y2gtc3RyaW5nIDIgcGF0aCkpCi0gICAgICAgICAg IDs7IERvIG5vdCByZW9yZGVyLCBgc3RyaW5nLXRyaW0nIG1vZGlmaWVzIG1hdGNoLgotICAg ICAgICAgICAoZmlsZSAoc3RyaW5nLXRyaW0gKG1hdGNoLXN0cmluZyAxIHBhdGgpKSkpCisg ICAgICAgICAgIDs7IERvIG5vdCByZW9yZGVyLCBgb3JnLXRyaW0nIG1vZGlmaWVzIG1hdGNo LgorICAgICAgICAgICAoZmlsZSAob3JnLXRyaW0gKG1hdGNoLXN0cmluZyAxIHBhdGgpKSkp CiAgICAgICAoY29ucwogICAgICAgIChpZiAob3JnLXN0cmluZy1udy1wIGZpbGUpIGZpbGUg ImRpciIpCi0gICAgICAgKGlmIChvcmctc3RyaW5nLW53LXAgbm9kZSkgKHN0cmluZy10cmlt IG5vZGUpICJUb3AiKSkpKSkKKyAgICAgICAoaWYgKG9yZy1zdHJpbmctbnctcCBub2RlKSAo b3JnLXRyaW0gbm9kZSkgIlRvcCIpKSkpKQogCiAoZGVmdW4gb3JnLWluZm8tZGVzY3JpcHRp b24tYXMtY29tbWFuZCAobGluayBkZXNjKQogICAiSW5mbyBsaW5rIGRlc2NyaXB0aW9uIHRo YXQgY2FuIGJlIHBhc3RlZCBhcyBjb21tYW5kLgpAQCAtMTA2LDcgKzEwNSw3IEBAIElmIExJ TksgaXMgbm90IGFuIGluZm8gbGluayB0aGVuIERFU0MgaXMgcmV0dXJuZWQuIgogICAgICAg ICAgKG5lZWQtZmlsZS1ub2RlIChhbmQgKG5vdCAob3JnLXN0cmluZy1udy1wIGRlc2MpKQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1wcmVmaXgtcCBwcmVmaXgg bGluaykpKSkKICAgICAocGNhc2UgKGFuZCBuZWVkLWZpbGUtbm9kZQotICAgICAgICAgICAg ICAgIChvcmctaW5mby0tbGluay1maWxlLW5vZGUgKHN0cmluZy1yZW1vdmUtcHJlZml4IHBy ZWZpeCBsaW5rKSkpCisgICAgICAgICAgICAgICAgKG9yZy1pbmZvLS1saW5rLWZpbGUtbm9k ZSAob3JnLXVuYnJhY2tldC1zdHJpbmcgcHJlZml4ICIiIGxpbmspKSkKICAgICAgIDs7IFVu bGlrZSAoaW5mbyAiZGlyIiksICJpbmZvIGRpciIgc2hlbGwgY29tbWFuZCBvcGVucyAiKGNv cmV1dGlscylkaXIgaW52b2NhdGlvbiIuCiAgICAgICAoYCgiZGlyIiAuICJUb3AiKSAiaW5m byBcIihkaXIpXCIiKQogICAgICAgKGAoLGZpbGUgLiAiVG9wIikgKGZvcm1hdCAiaW5mbyAl cyIgZmlsZSkpCmRpZmYgLS1naXQgYS9saXNwL29yZy1tYWNzLmVsIGIvbGlzcC9vcmctbWFj cy5lbAppbmRleCAxM2Q4NzJhODIuLjJlNDU5MGU5MyAxMDA2NDQKLS0tIGEvbGlzcC9vcmct bWFjcy5lbAorKysgYi9saXNwL29yZy1tYWNzLmVsCkBAIC0xMTAxLDcgKzExMDEsOCBAQCBy ZW1vdmVkLiAgUmV0dXJuIHRoZSBuZXcgc3RyaW5nLiAgSWYgU1RSSU5HIGlzIG5pbCwgcmV0 dXJuIG5pbC4iCiAgIChhbmQgc3RyaW5nCiAgICAgICAgKGlmIChhbmQgKHN0cmluZy1wcmVm aXgtcCBwcmUgc3RyaW5nKQogCQkoc3RyaW5nLXN1ZmZpeC1wIHBvc3Qgc3RyaW5nKSkKLQkg ICAoc3Vic3RyaW5nIHN0cmluZyAobGVuZ3RoIHByZSkgKC0gKGxlbmd0aCBwb3N0KSkpCisJ ICAgKHN1YnN0cmluZyBzdHJpbmcgKGxlbmd0aCBwcmUpCisgICAgICAgICAgICAgICAgICAg ICAgKGFuZCAobm90IChzdHJpbmctZXF1YWwgIiIgcG9zdCkpICgtIChsZW5ndGggcG9zdCkp KSkKIAkgc3RyaW5nKSkpCiAKIChkZWZ1biBvcmctc3RyaXAtcXVvdGVzIChzdHJpbmcpCi0t IAoyLjI1LjEKCg== --------------TjgxGCS6v4Xihqn3FJDDUvCs--