From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kGSFF48yEmPeEwAAbAwnHQ (envelope-from ) for ; Fri, 02 Sep 2022 18:42:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aBanFo8yEmO2QwAAG6o9tA (envelope-from ) for ; Fri, 02 Sep 2022 18:42:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C312936F06 for ; Fri, 2 Sep 2022 18:42:54 +0200 (CEST) Received: from localhost ([::1]:44618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU8nq-0004ux-Nq for larch@yhetil.org; Fri, 02 Sep 2022 11:41:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU8nQ-0004su-H1 for emacs-orgmode@gnu.org; Fri, 02 Sep 2022 11:41:28 -0400 Received: from ciao.gmane.io ([116.202.254.214]:39344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU8nP-0003gH-3E for emacs-orgmode@gnu.org; Fri, 02 Sep 2022 11:41:28 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oU8nM-00067z-49 for emacs-orgmode@gnu.org; Fri, 02 Sep 2022 17:41:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] org.el: Fix percent substitutions in `org-open-file' Date: Fri, 2 Sep 2022 22:41:18 +0700 Message-ID: References: <874kih92nb.fsf@kyleam.com> <87mtw8fupl.fsf@kyleam.com> <87tu5qm11q.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <87tu5qm11q.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662136975; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Jz0+0RM/nYAiNbfmhZCL2biJO2r12nLF5AJn3aP+mX0=; b=JbE97x6MnGv6Iz7VNHDmL0DSvrRw0yaltryTJKNaUj5qdYPjVHkm2hJ7g9d0eLQn2obODv QI8QhZTuUijoWiZ2qOIScMSy1bNApPXz2bkJ95G+BS7ACYDkpRil3nR1Ee+Pw1bm/sb4/P MxN0MYN/XapwKUCkg7EsbZDRz9yKx7iHvBn5xVYlw4bFfKdfy8xC3Uajr27Q2Y2w3pqseE NpOCHvPW6UBMNXDLKnezu+tZKFg9otpknIZCJ0NDqJba/7nYcNKpuaHi7lWyOBYctm6rSV 7ZKksyDBbqPQXRbqZl9NV4iMI4tHT8ufJaw+QxxbtL1Emid8IsHqqgnNFMsR3w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662136975; a=rsa-sha256; cv=none; b=bexxCFwWY+rvMzM8DeBHQmdqTvHQUkVf23XUcAweidH0tZ9cDF+4MtUl6TLMEHWICcMEN4 VQ2bMnKtrIUAPttBS/8TaJgWAOC+cCRFcSmknYbLbN9lB/1q31tCQwvc94BwVKT1GSBbgR 0eJByd6NOE9UMjH/px/bmNO9tiqHhtyZnviPsF+sNgot5faEPwsVuCLkAvKQ3ZYFeaYq7t FwJl4rUGYqWnEA1Hi1bwub26Ck9qioES4k/SsMA3DWsBiZO6wXj4KENyi1PvCoKMSz0PPr mDUwWjGk3fm2YlP3F9/SlyKffD0d12QR1SWxpCaojJd1K+9k0MYeRFlVVdsnoQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C312936F06 X-Spam-Score: 3.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: UBWZkKkEAoW2 On 02/09/2022 19:08, Ihor Radchenko wrote: > Max Nikulin writes: > >> Subject: [PATCH] org.el: Fix percent substitutions in `org-open-file' > >> +(defun org--open-file-format-command >> + (mailcap-command file link match-data) >> + "Format MAILCAP-COMMAND to launch viewer for FILE. >> + >> ... >> +For example, to specify particular location withing a PDF file, >> +`org-file-apps' list may have the following entries (order is important): >> + >> + ;; Page and search string, >> + ;; e.g. . >> + (\"\\\\.pdf::\\\\([0-9]+\\\\)::\\\\(.+\\\\)\\\\\\='\" >> + . \"okular --page %1 --find %2 %s\") >> + ;; Internal anchor and search string, >> + ;; e.g. . In the meanwhile I have realized that it should be To allow just search as >> + (\"\\\\.pdf::\\\\(.+\\\\)::\\\\(.+\\\\)\\\\\\='\" >> + . \"okular --find %2 file://%s\\\\\\\\#%1\") >> + ;; Page number, e.g. . >> + (\"\\\\.pdf::\\\\([0-9]+\\\\)\\\\\\='\" . \"okular --page %1 %s\") >> + ;; Internal reference, e.g. . And As a side effect it should dramatically reduce number of backslashes since hash symbol becomes a part of %1 substitution. >> + (\"\\\\.pdf::\\\\(.+\\\\)\\\\\\='\" . \"okular file://%s\\\\\\\\#%1\") >> + ;; No location within the file, optionally followed by \"::\", >> + ;; e.g. . >> + (\"\\\\.pdf\\\\(?:::\\\\)?\\\\\\='\" . \"okular %s\") > > This is a nice set of examples, but it probably does not belong to this > docstring. I'd rather see this in `org-file-apps' docstring or even in > the manual. I thought on this and I do not think it should be added to the manual. Instead a set of hooks should be defined for popular PDF viewers: evince, zathura, xpdf, firefox, chromium & Co, etc. Such hook injects a number of supported `org-file-apps' records and users may add suitable hook to e.g. (with-eval-after-load 'org (push ...)). It may be implemented as a dedicated package org-pdf-viewers.el. The only problems is that adding entries programmatically breaks easy customization interface for `org-file-apps'. Currently there is the same issue with `org-link-parameters' that is a defcustom variables with entries added by various org extensions. I added the example with hope to better explain the purpose of this function.