From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CB86F8ZbBWTjcgAAbAwnHQ (envelope-from ) for ; Mon, 06 Mar 2023 04:19:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EGYnF8ZbBWRwSAAAauVa8A (envelope-from ) for ; Mon, 06 Mar 2023 04:19:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 36B8B3C18D for ; Mon, 6 Mar 2023 04:19:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZ1My-0001Sq-Eq; Sun, 05 Mar 2023 22:18:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZ1Mw-0001S4-GT for emacs-orgmode@gnu.org; Sun, 05 Mar 2023 22:18:34 -0500 Received: from out162-62-57-210.mail.qq.com ([162.62.57.210]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZ1Mr-0007QU-OI for emacs-orgmode@gnu.org; Sun, 05 Mar 2023 22:18:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1678072699; bh=YpdmkEiM8Acgcxemy4eS3yIrITMsGCaOt0ecf3PThSs=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=nHMP5W3jpgICQLKxRgu7KAeD6Fe9KK0ccJmMODrKMdrXOuIENMdg+XCW82B8TQ9wI GKNppOEZqm5iaxGGwACJ6ELzb+LevLnqeQ5dobc6bVJDv7DLuloeL7yXdk8SGRdhf+ NhfTiPyITGu9RTmeoCaTjByrxrfd9aB9RbZlkMMM= Received: from [10.8.192.150] ([140.210.194.131]) by newxmesmtplogicsvrszb9-0.qq.com (NewEsmtp) with SMTP id 442A4EA5; Mon, 06 Mar 2023 11:17:02 +0800 X-QQ-mid: xmsmtpt1678072622th8whoa52 Message-ID: X-QQ-XMAILINFO: MB5+LsFw85NonJxWmj+vpBusk6WrWlKspmQ1coTxz1x1C2rYBNgy5EQjv/D1a+ jr2OxFuH/0tW89Lp+bY8Bo66Rhio7gzBgo0R94lvHu9wk7gXyDqUFdW80K9acrB3vaoqc76oEVht d+7rXHVjMS6+r7j13isjDred3VmJZJKDvrGzjbyOKTl9M5y3eMoa+pra/d+Xztutor0xWWLk9bbt mMzumq5ssKzjyBeYo9x6FZ4YqSqXCOUoyycb8Qe9qYKVwSvaF7u0+4hAxhbJytE6N+mdeHjawGhl P/vkKSUNuviYEYmqlLzCWiLt4ZgQBrb6Pe8JA9jVFo1FhrRTQe6pPRs7RoRaLHtAHKvhzZf6JPxR K0vogtSQenECAy7EO+iRRS+OsMuBcFlkS6jX7GqC32kUhRJtf7SK9BkT/rVSsIrDRAG4M99VKPuG QnpnfwKqQ7nWzfDmEBPWrCAu6NJ6mVr6yusPPk4PvPMpN7o23o7k8o0Rm5DinWaKKkF74uWxwkNe WzhGKvS4IsZCvjA3CKDm3lcJKgwsAQuUtqhzMxQKLh/J9KiME1UGftAMYyODZAsAJIFiItE8/ygm KAAH+RW+Dfnv+xanPHsiJxVLUmnUFVPARzaInUjY8gzwAe5LdrjTK25uCTDWfS679A1B5ZXKx1a7 2bERI8/QwpODAkK5AJsf6KdrMX3fkkPXG/28Tck0tZF/HU1HJNaTwzctMYayMgvGIJALYo7pwTG1 mVeyLcDfT+x29XiEDWieQOm4BswFDhY1qV8oa0H2nKmCHbpocYO3B+lqnqomuyqUKmpzpzchjNMG 9isfcW8jqqhENFnjLYPL3nO4nQdSISIUtQyg//xD+oBgrQlUFjNX9dxm0y0txc8LMODgFeAvDlbs fps/DsCmDi7I44ptBHX/HJF6y1FIepnjDwx5RMN7csRLYIUASTilBgFUFO1IN24Cegn5mG4ZeV X-OQ-MSGID: <448068839a49d7b64b80e4ab0237a64937bef8e6.camel@shellcodes.org> Subject: Re: [PATCH] Fix ob-latex.el command injection vulnerability. From: lux To: Ihor Radchenko Cc: Max Nikulin , emacs-orgmode@gnu.org Date: Mon, 06 Mar 2023 11:17:02 +0800 In-Reply-To: <87v8jzjj1p.fsf@localhost> References: <87v8jzjj1p.fsf@localhost> Content-Type: multipart/mixed; boundary="=-LSXFk/P7v3ffDZUWvzo4" User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Received-SPF: none client-ip=162.62.57.210; envelope-from=lx@shellcodes.org; helo=out162-62-57-210.mail.qq.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678072773; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YpdmkEiM8Acgcxemy4eS3yIrITMsGCaOt0ecf3PThSs=; b=CM6htc6b5afS/qBV/myt2V7vvXElPyKhTUDe+FkFIypGWcvTG0YVfxXM4y2IUKLYNGYIhX 6EzozUOXSShLWQMbBz78njLcPSTpe+PZIJ8gdF+eDxBjfqek3Q2TqaE0iClqfQyLwC7Ub7 hERWlesB0JLlFEPklwHUNfI4IQ6lBxcv8es2g6PnV/MZgIzXnzkBzDYvqwWxM2HLKeWFkX Ke1VZrrMlqUchCj7PNA75ivwQwfwvwieA1swUgnQeHbD8zE3Zc8kCFhIaS9/U7LWAzS3tB rp/ZtsgIcxzwJyJhwSC/dTZlJNBjvId0cdLgqPTq3kKhd/infTX27WiW3ReHug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=qq.com header.s=s201512 header.b=nHMP5W3j; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678072773; a=rsa-sha256; cv=none; b=Ift2SwSf59AEun0vqIulAn1czIyKI9shMMN2SKN6D0YuKHA1Us7KVP4lU56pxa1auL9kCs ISOsVEmeaSS+4tVc2BtnqVaY2/aXQsAY0y58wOVFStdIsVONbOKJi5qZaICfY+VJwLbaZN FrtbmnRbqW+bnF4XLkEXufLLEC2s/FUEEzg504sJCjtPaDmS13lkeIJ27MFzAsLy3Pz7jJ qD/14IvD1JE8J4sySv7Xg8pd0lInFlVqIl4JUJowaXXDtWtnB3xCCCpiFAKwSib/1jjCI1 A5sPAq8Wl5vPWtMdbXbBtznVKZG5FDhmM9LRdekqUpikIbwrGkBMOct6TGfpzg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.44 X-Spam-Score: -4.44 X-Migadu-Queue-Id: 36B8B3C18D Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=qq.com header.s=s201512 header.b=nHMP5W3j; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: Y4FV8EXI6KuP --=-LSXFk/P7v3ffDZUWvzo4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2023-02-18 at 11:43 +0000, Ihor Radchenko wrote: > lux writes: >=20 > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (shell-command (format "mv %s %s" img-out out- > > file))))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (rename-file img-out out-file)))) >=20 > I think should be (rename-file img-out out-file t) >=20 Fixed, thank you. --=-LSXFk/P7v3ffDZUWvzo4 Content-Disposition: attachment; filename*0=0001-lisp-ob-latex.el-org-babel-execute-latex-Fix-command.pat; filename*1=ch Content-Type: text/x-patch; name="0001-lisp-ob-latex.el-org-babel-execute-latex-Fix-command.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBhZGMwYzU1OGIxYjA5MWJiNGJlZjc3OTAxNjMzZjMxMzQ0YjczOTFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaSBMdSA8bHhAc2hlbGxjb2Rlcy5vcmc+CkRhdGU6IFNhdCwg MTggRmViIDIwMjMgMTg6MDM6MjggKzA4MDAKU3ViamVjdDogW1BBVENIXSAqIGxpc3Avb2ItbGF0 ZXguZWwgKG9yZy1iYWJlbC1leGVjdXRlOmxhdGV4KTogRml4IGNvbW1hbmQKIGluamVjdGlvbiB2 dWxuZXJhYmlsaXR5LgoKLS0tCiBsaXNwL29iLWxhdGV4LmVsIHwgMiArLQogMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vYi1s YXRleC5lbCBiL2xpc3Avb2ItbGF0ZXguZWwKaW5kZXggNDI4OTA3YTI3Li4wZDBhMzdhMDIgMTAw NjQ0Ci0tLSBhL2xpc3Avb2ItbGF0ZXguZWwKKysrIGIvbGlzcC9vYi1sYXRleC5lbApAQCAtMTgw LDcgKzE4MCw3IEBAIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGJ5IGBvcmctYmFiZWwtZXhlY3V0 ZS1zcmMtYmxvY2snLiIKIAkgICAgICAgICAgICAgICAgICAgICB0bXAtcGRmCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChsaXN0IG9yZy1iYWJlbC1sYXRleC1wZGYtc3ZnLXByb2Nlc3Mp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGV4dGVuc2lvbiBlcnItbXNnIGxvZy1idWYp KSkKLSAgICAgICAgICAgICAgKHNoZWxsLWNvbW1hbmQgKGZvcm1hdCAibXYgJXMgJXMiIGltZy1v dXQgb3V0LWZpbGUpKSkpKQorICAgICAgICAgICAgICAocmVuYW1lLWZpbGUgaW1nLW91dCBvdXQt ZmlsZSB0KSkpKQogICAgICAgICAgKChzdHJpbmctc3VmZml4LXAgIi50aWt6IiBvdXQtZmlsZSkK IAkgICh3aGVuIChmaWxlLWV4aXN0cy1wIG91dC1maWxlKSAoZGVsZXRlLWZpbGUgb3V0LWZpbGUp KQogCSAgKHdpdGgtdGVtcC1maWxlIG91dC1maWxlCi0tIAoyLjMwLjIKCg== --=-LSXFk/P7v3ffDZUWvzo4--