From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4FlIGbZb92IZdAEAbAwnHQ (envelope-from ) for ; Sat, 13 Aug 2022 10:07:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CNVpGLZb92JTLAAAG6o9tA (envelope-from ) for ; Sat, 13 Aug 2022 10:07:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 270A138418 for ; Sat, 13 Aug 2022 10:07:18 +0200 (CEST) Received: from localhost ([::1]:58002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMmAv-0004wD-Cc for larch@yhetil.org; Sat, 13 Aug 2022 04:07:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMmAA-0004vq-Jr for emacs-orgmode@gnu.org; Sat, 13 Aug 2022 04:06:30 -0400 Received: from ciao.gmane.io ([116.202.254.214]:59832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMmA7-0007ZJ-B6 for emacs-orgmode@gnu.org; Sat, 13 Aug 2022 04:06:29 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oMmA0-0006V5-CX for emacs-orgmode@gnu.org; Sat, 13 Aug 2022 10:06:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: =?UTF-8?B?UmU6IFtQQVRDSF0gb2ItdGFuZ2xlLmVsOiBmaXgg4oCYOmNvbW1lbnRz?= =?UTF-8?Q?_noweb=e2=80=99_double_linking?= Date: Sat, 13 Aug 2022 15:06:14 +0700 Message-ID: References: <01070182484e44f3-f0fd271a-def3-4c86-961f-9a4bb63949d5-000000@eu-central-1.amazonses.com> <87wnbvtcz9.fsf@localhost> <87o7wr9zhw.fsf@localhost> <87o7wo7igw.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <87o7wo7igw.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660378038; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ImNgqmjAgRWvJsteWzD8+44o08xEv7/WYWcZgClbzu8=; b=ubKVHkHbYPjVawhPRbshDXCNltAPqcahidxaJ2z2Nyfv/r0onPOncQU7k/e/54nvCHLLOa bQrFKkBDMuj0gVF3L8mgxQ6hExzXhC+zJThPuO4mA6F/g1OToyjxF2yS9y4haPSFiACpVi CLEH14fEX8K8K/Vh0QdJoeg9Y4/caZNli1ALAOW1kyAdLEQKIh1zX3ZcUymTVS0iekH5Yt tZhwogY8RQVrULGxgjLX0v4B1wF5quqltbCkNwi+vxFsSTcwG50zL0VK4GLMicA6CtuEbW VeKVSZGamBuqeCFNyRN/4EzPtvT9PaLWvHqdkb9HpVAOKyauOybQBeYRMFGp9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660378038; a=rsa-sha256; cv=none; b=NbJszMoF+qg0qJxdWiMnHQk2KNy2sgEeC+1zXMg0n0T4Lm5zHTGCrr2QxaowHEV4D7Epcy Xa4PZghHHisYJ/kFAFnlsJHKPK26mFhoum2y/VZxgQ2P/VLTB+hAVm15ySW3esfySXM3Fd iT2dvTHpyOGbk327+Cr5Q5Xh/c9OCluOrROE9ksbvFD18yGThHKBRd60zT0LWDRZlAvsZE a/C3TqR1tVKsPd2HsfufIPXVpOlu6LB4VS758l0v4U3RCcWOuZi3wd13vxEo2qISy4Y7vB caXvBxciurWGBczKzVSTvnmgTBnAhVFut0AFY841gfiWgGV2veJQ17o4K01FUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.54 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 270A138418 X-Spam-Score: 3.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2Pgi0FM0F3h5 On 13/08/2022 13:42, Ihor Radchenko wrote: > Max Nikulin writes: > >>> + (bare (and (string-match org-link-bracket-re l) >>> + (match-string 1 l)))) >>> + (when bare >>> + (if (and org-babel-tangle-use-relative-file-links >>> + (string-match org-link-types-re bare) >>> + (string= (match-string 1 bare) "file")) >> >> It looks like (string-prefix-p "file:" bare) but without the complex >> regexp. I see, such code was used before. By the way, why it is "bare", >> not e.g. "target"? > > match-end is used later in the code. Thus, string-match is justified. The matched string is always "file:", so there is no actual point in `string-match'. It does not really matter however. (let ((params '((:tangle . "/home/user/file.el"))) (type "file:") (target "file:///dev/null")) (if (and target org-babel-tangle-use-relative-file-links (string-prefix-p type target)) (concat type (file-relative-name (substring target (length type)) (file-name-directory (alist-get :tangle params)))) target)) In the code existed before and moved by the committed patch I do not like that "then" branch of the `if' form uses side effect of evaluation of the condition.