From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking
Date: Thu, 11 Aug 2022 22:00:15 +0700 [thread overview]
Message-ID: <td35i0$4k0$1@ciao.gmane.io> (raw)
In-Reply-To: <c6aa8623-852c-e5ff-5f10-d0752fd6ba66@0brg.net>
On 11/08/2022 03:54, Hraban Luyat wrote:
> On 8/3/22 11:55 AM, Max Nikulin wrote:
>
> Do you mean to rewrite
>
> (when bare (if x y bare))
>
> to this?
>
> (and bare x y)
>
> If that's what you meant, I think it would evaluate differently if bare
> = truthy and x = falsy, right? Form 1 evaluates to `bare', form 2
> evaluates to x (i.e. NIL). Or did I misunderstand the suggestion?
You are right. I tried to suggest an expression that was wrong.
I am going to make another attempt:
(if (and bare
org-babel-tangle-use-relative-file-links
(string-match org-link-types-re bare)
(string= (match-string 1 bare) "file"))
(concat "file:"
(file-relative-name (substring bare (match-end 0))
(file-name-directory
(cdr (assq :tangle params)))))
bare)
I do not think that such code is dramatically clearer, but at least it
has 1 conditional form less.
next prev parent reply other threads:[~2022-08-11 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 4:54 [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking Hraban Luyat
2022-07-30 4:56 ` Ihor Radchenko
2022-07-30 23:42 ` Hraban Luyat
2022-08-03 11:40 ` Ihor Radchenko
2022-08-03 15:55 ` Max Nikulin
2022-08-10 20:54 ` Hraban Luyat
2022-08-11 4:26 ` Ihor Radchenko
2022-08-12 2:21 ` Hraban Luyat
2022-08-12 13:16 ` Max Nikulin
2022-08-13 6:42 ` Ihor Radchenko
2022-08-13 8:06 ` Max Nikulin
2022-08-14 3:20 ` Ihor Radchenko
2022-08-13 6:40 ` Ihor Radchenko
2022-08-11 15:00 ` Max Nikulin [this message]
2022-08-03 11:31 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='td35i0$4k0$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).