From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wFYDGIad6mKBvQAAbAwnHQ (envelope-from ) for ; Wed, 03 Aug 2022 18:08:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IMkXGIad6mLbNQAA9RJhRA (envelope-from ) for ; Wed, 03 Aug 2022 18:08:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03D69948E for ; Wed, 3 Aug 2022 18:08:38 +0200 (CEST) Received: from localhost ([::1]:34602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJGvF-0001n6-3Q for larch@yhetil.org; Wed, 03 Aug 2022 12:08:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGqJ-0006Dq-Db for emacs-orgmode@gnu.org; Wed, 03 Aug 2022 12:03:31 -0400 Received: from ciao.gmane.io ([116.202.254.214]:60532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGqH-0004rP-Tm for emacs-orgmode@gnu.org; Wed, 03 Aug 2022 12:03:31 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oJGqF-0007b0-R9 for emacs-orgmode@gnu.org; Wed, 03 Aug 2022 18:03:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)] Date: Wed, 3 Aug 2022 23:03:20 +0700 Message-ID: References: <87k084v1wa.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US In-Reply-To: <87k084v1wa.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659542918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9heS958Kr4nFyWD106UcJZw+9f4Ho6qjPER56IsRcuU=; b=HZXsXdOjEpya3ptoNiKmwZ80a5RcKKD2bCiTX89RhahKvmgTp6w33aeVcDhWrsOADaTmTN Q3N+mv6BDAf5YyL293zXd+LEEDD1y2jSVeoKwvRn+QBdNJSa7xPeaJDI9IFJ/P+M22vji4 YE/HT0ED4mqNZIvwGkZJrCrnM0Gvpfkru1kX28KknEKL9fW6w2HvJzVqbztTqslwZzQpyI xR5YYQ+JhLwrqioqRkzGlzliu4jMezJtMnCc/YYskstoXw/kFII5fu6r9XS1/m1UNt7HN2 1yaxCbxKu7Wq6U2Umwu/pIP/c6UHtX8b+ijGDQXhhzFQCevS06Bb8aItQ3WbMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659542918; a=rsa-sha256; cv=none; b=nGahuEEp3YbLwQoIUv4WH8+vFB9prwvcwmUejSjPKQ5xnNARLSFsIGTJGOS1NREMimTt88 5P0YpEQIb1eoU8338FzHxDZI74d0Y2SrNJjstnlvRMVQhDhGemPXh9VL8Gn1XbOW8RrYmv f5hu4/z9UbNzbWPcvFTTQKalwWt+3BqU6qUC3QdtVJZ7UqskJkdb6fzj5rSrykPcer4H2v D97JOe+KniXmZWL0J9E5DP/78oeNEVqv75e8Fg/RT1PkhM8uliqgIu8wPOcZRahCcZk0YQ syITC3RQT+P355Xdl/OP7FbrDVZN0z4yPzs34xE/Ew9aRPvIeADs1kbpNjL0tA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.49 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03D69948E X-Spam-Score: 3.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: lNR7UWUn0RZD On 23/07/2022 12:22, Ihor Radchenko wrote: > Tentative patch is attached. > + (if (< (length id) 3) > + (org-attach-id-uuid-folder-format (md5 id)) Ihor, I am afraid of collisions due to short input to md5. Long hash value gives false impression of high entropy but actually there are not so many variants for 1 or 2 characters strings. Either there is no point in making long name from short id or random string of appropriate length should be used instead.