emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] New remote resource download policy
Date: Wed, 22 Jun 2022 23:55:15 +0700	[thread overview]
Message-ID: <t8vhhl$cfk$1@ciao.gmane.io> (raw)
In-Reply-To: <87pmj1nh7v.fsf@gmail.com>

On 22/06/2022 17:01, Timothy wrote:
> 
>>> +(defun org–confirm-resource-safe (uri)
>>> +  “Ask the user if URI should be considered safe, returning non-nil if so.”
>>> +    (unless noninteractive
>>> +      (let ((buf (get-buffer-create “*Org Remote Resource*”)))
>>
>> I see your intention to add something fancy to the dialog. May `org-mks’ be
>> reused instead to avoid proliferation variants of rather similar UI code?
> 
> Well, the thing here is that I’m explicitly trying to mimic the
> file-local-variable dialog, and since a general form isn’t exposed by Emacs, a
> little bit of proliferation seems like the best option to me.

 From my point of view the result is rather close (prompt should be 
adjusted):

(let ((uri "https://orgmode.org"))
   (org-mks
    nil
    (format "An org-mode document would like to download %s, which is 
not considered safe.

Do you want to download this?"
	   (propertize uri 'face '(:inherit org-link :weight normal)))
    nil ; prompt
    `((,(propertize "!" 'face 'success)
       "download this resource, and permanantly mark it as safe.")
      (,(propertize "y" 'face 'warning)
       "to download this resource, just this once.")
      (,(propertize "n" 'face 'error)
       "skip this resource."))))



  reply	other threads:[~2022-06-22 16:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12 14:43 Timothy
2022-06-12 16:18 ` Daniel Fleischer
2022-06-14  9:40 ` Robert Pluim
2022-06-22  9:58   ` Timothy
2022-06-15 12:35 ` Max Nikulin
2022-06-22 10:01   ` Timothy
2022-06-22 16:55     ` Max Nikulin [this message]
2022-06-29 15:27       ` Timothy
2022-06-30 16:57         ` Max Nikulin
2022-07-16  9:47           ` Timothy
2022-06-25  7:50     ` Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='t8vhhl$cfk$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] New remote resource download policy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).