emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-capture autoload bug? [9.5.2 (9.5.2-gfbff08 @ /home/ignacio/.emacs.d/elpa/org-9.5.2/)]
Date: Sun, 12 Jun 2022 19:36:06 +0700	[thread overview]
Message-ID: <t84mjn$10r7$1@ciao.gmane.io> (raw)
In-Reply-To: <877d5nba1s.fsf@localhost>

On 11/06/2022 20:32, Ihor Radchenko wrote:
> Ignacio Casso writes:
> 
>> Then we should decide if we want to use autoload cookies for custom
>> variables to make this work also with lexical binding. Otherwise, code
>> like the snippet above would produce an error in Emacs 29, and in Emacs
>> 27 the let binding would be ignored (although at least the custom setter
>> would work). I have no opinion regarding this last point since I don't
>> remember what were the disadvantages of using autoload cookies for
>> custom variables.
> 
> AFAIK, autoloading defcustoms is not discussed in the manual. I have no
> idea about possible pitfalls as well.

I have impression that it is not encouraged, but Emacs sources have 
enough examples of such autoloading. I posted some links earlier in the 
discussion of this issue, see
Max Nikulin, Fri, 11 Mar 2022 17:07:03 +0700.
https://list.orgmode.org/c58ae4d5-dd66-0d06-a332-cfdf23e1889e@gmail.com

> LGTM! Unless others have objections, I am inclined to merge the patch
> fully.

I see clear intention of improvement, but I have no particular opinion 
if the patch is risky. I worry a bit that some code related to this 
issue has changed in the development branch of Emacs, so I am unsure 
concerning behavior in earlier versions. I do not object committing the 
patch since it can be reverted later if some problem would arise.



  parent reply	other threads:[~2022-06-12 12:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  7:50 [BUG] org-capture autoload bug? [9.5.2 (9.5.2-gfbff08 @ /home/ignacio/.emacs.d/elpa/org-9.5.2/)] Ignacio Casso
2022-06-11 13:32 ` Ihor Radchenko
2022-06-11 17:25   ` Ignacio Casso
2022-06-14  4:02     ` Ihor Radchenko
2022-06-14  7:49       ` Ignacio Casso
2022-06-14 13:58         ` Ihor Radchenko
2022-06-12 12:36   ` Max Nikulin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-10 12:53 Ignacio Casso
2022-03-10 16:32 ` Max Nikulin
2022-03-10 18:00   ` Ignacio Casso
2022-03-11 10:07     ` Max Nikulin
2022-03-11 10:38       ` Ignacio Casso
2022-03-11 19:59         ` Tim Cross
2022-03-14 10:42           ` Ignacio Casso
2022-03-14 14:52           ` Max Nikulin
2022-03-14 18:42             ` Tim Cross
2022-03-14 19:43               ` Ignacio Casso
2022-03-14 22:54                 ` Tim Cross
2022-03-15  9:02                   ` Ignacio Casso
2022-03-15 15:59                     ` Ignacio Casso
2022-03-15 12:04                 ` Max Nikulin
2022-03-15 12:26                   ` Ignacio Casso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='t84mjn$10r7$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).