emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-maxima.el: Fix execution on MS Windows
Date: Tue, 11 Jan 2022 20:55:05 +0700	[thread overview]
Message-ID: <srk27q$158f$1@ciao.gmane.io> (raw)
In-Reply-To: <8cd49b4c-9342-a77f-d665-402c41432b57@gmail.com>

Nikolay, I do not have any objections concerning the last version of 
your patch (I have not test it though). It is tracked on 
https://updates.orgmode.org/ however it may take months before it will 
be committed.

Have you signed FSF papers related to copyright? See 
https://orgmode.org/worg/org-contribute.html#copyright There is no 
"TINYCHANGE" keyword in the commit message and I have not found you in 
the list of contributors to Org mode (Bastien likely have access to more 
actual data). Since several your patches have been accepted to Emacs, 
you are close to the limit when formalities become necessary.

Do not consider the comments below as a request to change anything in 
the patch. I am just trying to express more clear what I wrote in the 
previous message.

On 31/12/2021 03:54, Nikolay Kudryavtsev wrote:
>> When some external data is substituted into a Maxima command 
>> (batchload this case) there should be an extra pass of escaping that 
>> protects special characters like quotes (and backslashes?) accordingly 
>> to Maxima rules. 
> Not necessarily, Maxima is capable of understanding unescaped paths, for 
> example, this works:
> maxima --very-quiet -r "batchload(\"/tmp/sp 
> ce/babel-gxqTkM/maxima-ua3e9j.max\")"$

Consider a really peculiar path for tmp files with quotes

      /tmp/")$ something-weird$ "/maxima-ua3e9j.max

I hope, it is unrealistic and will be properly escaped by %S formatter. 
I am a bit surprised that Maxima does not allow to do it in a more 
reliable way since several interfaces exist (WxMaxima, texmacs). Unsure 
if get_application_args is suitable 

> Command line Maxima actually has a batch flag, but using it returns the 
> entire input file in the output too and that seems to be the reason why 
> the original authors of ob-maxima didn't use it.

It would be great if it had another flag to suppress printing content of 
the batch script or a flag that changes a setting that controls such 

  reply	other threads:[~2022-01-11 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26 20:18 [PATCH] ob-maxima.el: Fix execution on MS Windows Nikolay Kudryavtsev
2021-12-29 17:05 ` Max Nikulin
2021-12-29 18:37   ` Nikolay Kudryavtsev
2021-12-30 16:33     ` Max Nikulin
2021-12-30 20:54       ` Nikolay Kudryavtsev
2022-01-11 13:55         ` Max Nikulin [this message]
2022-10-29  6:08         ` Ihor Radchenko
2022-11-02 11:49           ` Nikolay Kudryavtsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='srk27q$158f$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).