From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-shell-test, test-ob-shell and introduction
Date: Thu, 6 Jan 2022 00:12:28 +0700 [thread overview]
Message-ID: <sr4ji5$dld$1@ciao.gmane.io> (raw)
In-Reply-To: <17e11edb77e.adb20ab5289948.958495178633735939@excalamus.com>
On 01/01/2022 02:18, Matt wrote:
>
> > Wow. Nice work!
>
> Thanks. I pushed things to Worg, if you haven't seen already
> (https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-shell.html).
> If you read it and find anything missing or unclear, please let me
> know.
Thank you, I was not aware of ":cmdline" argument and of ":shebang" as a
means to avoid stray prompts (I have seen mentions of similar problem
for other languages in this list).
I have noticed some glitches.
- https://www.mirbsd.org/pics/logo-grey.png works only with http:
protocol for me.
- I am unsure concerning example after "…or as a standlone script.",
maybe it should be wrapped into #+begin_example.
- In some cases "sh" is used despite bashisms in the code like "declare"
or "echo -ne". Actually "printf" may be more convenient instead of "echo -n"
- "export" in session example is unnecessary. It is matter of taste
though. Bash and dash is not the case, but some shells require that
assignment and export should be separate commands.
- In your examples variable values are simple. Often it is safer to add
double quotes around variable or command expansion. I would consider
adding quotes just to encourage people to do the same by default with
hope that less scripts will give strange results in response to a file
name containing a space. Actually my first impression was that
backslashes before quotes in some cases were added by mistake. Another
unescaped pair of quotes may make your intention more clear. However it
is related to code style where everybody has opinion, so I do not insist.
next prev parent reply other threads:[~2022-01-05 17:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:37 [PATCH] ob-shell-test, test-ob-shell and introduction Matt
2021-11-22 18:43 ` Timothy
2021-11-24 18:48 ` Matt
2021-12-02 9:39 ` Timothy
2021-12-06 3:50 ` Matt
2021-12-06 4:50 ` Thomas S. Dye
2021-12-18 7:03 ` Matt
2021-12-18 20:51 ` Thomas S. Dye
2021-12-31 17:04 ` Thomas S. Dye
2021-12-31 19:18 ` Matt
2021-12-31 22:11 ` Thomas S. Dye
2022-01-02 4:32 ` Matt
2022-01-02 18:57 ` Thomas S. Dye
2022-01-05 17:12 ` Max Nikulin [this message]
2022-01-06 3:47 ` Matt
2022-01-07 16:18 ` Max Nikulin
2021-11-22 19:08 ` Thomas S. Dye
2021-11-23 4:42 ` [PATCH] ob-doc-shell.org (was [PATCH] ob-shell-test, test-ob-shell and introduction) Matt
2021-11-23 4:59 ` Thomas S. Dye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='sr4ji5$dld$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).