From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qcOiGrCFzmFAPAEAgWs5BA (envelope-from ) for ; Fri, 31 Dec 2021 05:23:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EPeVErCFzmH3fwEAG6o9tA (envelope-from ) for ; Fri, 31 Dec 2021 05:23:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE13928A2E for ; Fri, 31 Dec 2021 05:23:11 +0100 (CET) Received: from localhost ([::1]:38356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n39Rf-0005Gh-0v for larch@yhetil.org; Thu, 30 Dec 2021 23:23:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n39RC-0005G6-JQ for emacs-orgmode@gnu.org; Thu, 30 Dec 2021 23:22:42 -0500 Received: from ciao.gmane.io ([116.202.254.214]:40578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n39RB-0006at-38 for emacs-orgmode@gnu.org; Thu, 30 Dec 2021 23:22:42 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n39R9-0009dY-Ke for emacs-orgmode@gnu.org; Fri, 31 Dec 2021 05:22:39 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] update ob-scheme to latest changes in geiser package Date: Fri, 31 Dec 2021 11:22:31 +0700 Message-ID: References: <8693346.QgZh8Glrbv@felipe-thinkpad-x200> <3749511.XVzDg1PN9u@felipe-thinkpad-x200> <3462869.oopU1TnKvU@felipe-thinkpad-x200> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <3462869.oopU1TnKvU@felipe-thinkpad-x200> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 17 X-Spam_score: 1.7 X-Spam_bar: + X-Spam_report: (1.7 / 5.0 requ) DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.024, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640924592; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=z+djr9P3OjHP6nH8Lfr4g3thM34VNUbMR2/QzG4ELic=; b=iEJDomPFfCqzf5oUDWcCAYhMdEnCclNRaG2Zjswqx0lZFIBa0e1A3sSbW9R8zT7MXR1snA POStfEULXpCCIdeuz973jL12M3oca5IN2X80J2lcV7t85dTXPu24VMMv2Yvnux1wBtPnoe nnOl1Y0YKvsSbRyD1kOodQuL7CD8d2G2ZtqpErJt5nho2VBmZPtsZTMNAJwyyoQAaK7AUO jBP+GQZkAhlqdsNc+KIz4WPAdTUtrAhQKMUhu/5asZZkRASbgsDPQvwqzQTj+vSeXG9Z3o L6yTdVkC8e9m/ilmccoXwAX0lHLUK8X6ma1e85U7fAlGku4exJ6OXuHzjEcrhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640924592; a=rsa-sha256; cv=none; b=OgIqwGOuvZ+j3N/nHkS+aaNNFZXG831qRaDoLXfcSqpyHRmTDkaF6c9HRuKjztg5axc7i7 BXju8/jhFx1QeqLkbayk8K5gDmUmzbwpRj653F62BS3+5zSCP/PW+sPaRUoammwGPWXaSm edgW2dx37afpJpkhWLTZCKGTaxiidHzFvAIhZdMYlEmK+oCktI0VDD8B47G//e1uoyLOKG 3SRAIaP3ICq236k/vFyR5JY8e6V9LPY3tUXusAjKP9n6L1N8/6oBtrMaQ8zxgpm+YimNhc lcAc+bJaI+9tE9kU42QOCjEuXHWex/81weedAIhT092pbiF6nzDkOR89MwKvZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.78 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DE13928A2E X-Spam-Score: -2.78 X-Migadu-Scanner: scn0.migadu.com X-TUID: M775TCYF8tdK On 31/12/2021 02:01, Felipe Lema wrote: > On Thursday, 30 December 2021 22:50:20 +07 Max Nikulin wrote: >> I would consider testing if `geiser-eval-region/wait' is bound and fallback to `geiser-eval-region' otherwise. > > I've wrapped an `if` to fallback to previous API before this breaking change in attached patch. Felipe, thanks for the patch. It is tracked on https://updates.orgmode.org Sometimes maintainers merge patches in large batches before a release, so it may takes months. > --- a/lisp/org/ob-scheme.el > +++ b/lisp/org/ob-scheme.el Almost certainly it should be "lisp/ob-scheme.el" without "org" in the middle. It is better to prepare patches using "git format-patch" since it allows to quickly create a commit with proper message and author using "git am" command. See https://orgmode.org/worg/org-contribute.html for details. > + ;; use `geiser-eval-region/wait' only when available > + ;; in newer versions of `geiser' Maybe specifying the version where new feature has been introduced would be helpful to maintainers to decide at which moment fallback code path can be removed. I have not tested if geiser works, but a comment to https://gitlab.com/emacs-geiser/geiser/-/issues/30 confirms it. It seems maintainers should check and update your status in respect to FSF papers on https://orgmode.org/worg/contributors.html since earlier you wrote that the procedure had been completed.