From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] update ob-scheme to latest changes in geiser package
Date: Fri, 31 Dec 2021 11:22:31 +0700 [thread overview]
Message-ID: <sqm0i8$13cg$1@ciao.gmane.io> (raw)
In-Reply-To: <3462869.oopU1TnKvU@felipe-thinkpad-x200>
On 31/12/2021 02:01, Felipe Lema wrote:
> On Thursday, 30 December 2021 22:50:20 +07 Max Nikulin wrote:
>> I would consider testing if `geiser-eval-region/wait' is bound and fallback to `geiser-eval-region' otherwise.
>
> I've wrapped an `if` to fallback to previous API before this breaking change in attached patch.
Felipe, thanks for the patch. It is tracked on https://updates.orgmode.org
Sometimes maintainers merge patches in large batches before a release,
so it may takes months.
> --- a/lisp/org/ob-scheme.el
> +++ b/lisp/org/ob-scheme.el
Almost certainly it should be "lisp/ob-scheme.el" without "org" in the
middle. It is better to prepare patches using "git format-patch" since
it allows to quickly create a commit with proper message and author
using "git am" command. See https://orgmode.org/worg/org-contribute.html
for details.
> + ;; use `geiser-eval-region/wait' only when available
> + ;; in newer versions of `geiser'
Maybe specifying the version where new feature has been introduced would
be helpful to maintainers to decide at which moment fallback code path
can be removed.
I have not tested if geiser works, but a comment to
https://gitlab.com/emacs-geiser/geiser/-/issues/30 confirms it.
It seems maintainers should check and update your status in respect to
FSF papers on https://orgmode.org/worg/contributors.html since earlier
you wrote that the procedure had been completed.
next prev parent reply other threads:[~2021-12-31 4:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 18:03 Felipe Lema
2021-12-30 1:53 ` Felipe Lema
2021-12-30 15:50 ` Max Nikulin
2021-12-30 19:01 ` Felipe Lema
2021-12-31 4:22 ` Max Nikulin [this message]
2022-02-06 9:50 ` Ihor Radchenko
[not found] <878rrw0w3x.fsf@terra.tmtvl.info>
2022-04-23 13:29 ` Tim Van den Langenbergh
2022-04-26 15:04 ` Felipe Lema
2022-04-27 8:44 ` Ihor Radchenko
2022-05-07 12:04 ` Tim Van den Langenbergh
2022-05-08 10:02 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='sqm0i8$13cg$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--subject='Re: [PATCH] update ob-scheme to latest changes in geiser package' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).